git/git.git
11 years agoMerge branch 'pc/uninteresting-submodule-disappear-upon-switch-branches'
Junio C Hamano [Tue, 19 Jan 2010 02:12:57 +0000 (18:12 -0800)]
Merge branch 'pc/uninteresting-submodule-disappear-upon-switch-branches'

* pc/uninteresting-submodule-disappear-upon-switch-branches:
  Remove empty directories when checking out a commit with fewer submodules

11 years agoMerge branch 'nd/include-termios-for-osol'
Junio C Hamano [Tue, 19 Jan 2010 02:12:53 +0000 (18:12 -0800)]
Merge branch 'nd/include-termios-for-osol'

* nd/include-termios-for-osol:
  Add missing #include to support TIOCGWINSZ on Solaris

11 years agoMerge branch 'js/windows'
Junio C Hamano [Tue, 19 Jan 2010 02:12:49 +0000 (18:12 -0800)]
Merge branch 'js/windows'

* js/windows:
  Do not use date.c:tm_to_time_t() from compat/mingw.c
  MSVC: Windows-native implementation for subset of Pthreads API
  MSVC: Fix an "incompatible pointer types" compiler warning
  Windows: avoid the "dup dance" when spawning a child process
  Windows: simplify the pipe(2) implementation
  Windows: boost startup by avoiding a static dependency on shell32.dll
  Windows: disable Python

11 years agoUpdate draft release notes to 1.7.0
Junio C Hamano [Mon, 18 Jan 2010 00:47:48 +0000 (16:47 -0800)]
Update draft release notes to 1.7.0

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'tc/test-locate-httpd'
Junio C Hamano [Mon, 18 Jan 2010 00:00:13 +0000 (16:00 -0800)]
Merge branch 'tc/test-locate-httpd'

* tc/test-locate-httpd:
  t/lib-http.sh: Restructure finding of default httpd location

11 years agoMerge branch 'jh/commit-status'
Junio C Hamano [Mon, 18 Jan 2010 00:00:07 +0000 (16:00 -0800)]
Merge branch 'jh/commit-status'

* jh/commit-status:
  t7502: test commit.status, --status and --no-status
  commit: support commit.status, --status, and --no-status

Conflicts:
Documentation/git-commit.txt
builtin-commit.c

11 years agoMerge branch 'jn/makefile'
Junio C Hamano [Sun, 17 Jan 2010 23:59:44 +0000 (15:59 -0800)]
Merge branch 'jn/makefile'

* jn/makefile:
  Makefile: consolidate .FORCE-* targets
  Makefile: learn to generate listings for targets requiring special flags
  Makefile: use target-specific variable to pass flags to cc
  Makefile: regenerate assembler listings when asked

11 years agoMerge branch 'jc/maint-1.6.1-checkout-m-custom-merge'
Junio C Hamano [Sun, 17 Jan 2010 23:59:40 +0000 (15:59 -0800)]
Merge branch 'jc/maint-1.6.1-checkout-m-custom-merge'

* jc/maint-1.6.1-checkout-m-custom-merge:
  checkout -m path: fix recreating conflicts

Conflicts:
t/t7201-co.sh

11 years agoMerge branch 'tc/clone-v-progress'
Junio C Hamano [Sun, 17 Jan 2010 23:58:58 +0000 (15:58 -0800)]
Merge branch 'tc/clone-v-progress'

* tc/clone-v-progress:
  clone: use --progress to force progress reporting
  clone: set transport->verbose when -v/--verbose is used
  git-clone.txt: reword description of progress behaviour
  check stderr with isatty() instead of stdout when deciding to show progress

Conflicts:
transport.c

11 years agoMerge branch 'tc/smart-http-restrict'
Junio C Hamano [Sun, 17 Jan 2010 23:58:23 +0000 (15:58 -0800)]
Merge branch 'tc/smart-http-restrict'

* tc/smart-http-restrict:
  Test t5560: Fix test when run with dash
  Smart-http tests: Test http-backend without curl or a webserver
  Smart-http tests: Break test t5560-http-backend into pieces
  Smart-http tests: Improve coverage in test t5560
  Smart-http: check if repository is OK to export before serving it

11 years agoMerge branch 'jk/run-command-use-shell'
Junio C Hamano [Sun, 17 Jan 2010 23:58:15 +0000 (15:58 -0800)]
Merge branch 'jk/run-command-use-shell'

* jk/run-command-use-shell:
  t4030, t4031: work around bogus MSYS bash path conversion
  diff: run external diff helper with shell
  textconv: use shell to run helper
  editor: use run_command's shell feature
  run-command: optimize out useless shell calls
  run-command: convert simple callsites to use_shell
  t0021: use $SHELL_PATH for the filter script
  run-command: add "use shell" option

11 years agoMerge branch 'sr/gfi-options'
Junio C Hamano [Sun, 17 Jan 2010 23:58:11 +0000 (15:58 -0800)]
Merge branch 'sr/gfi-options'

* sr/gfi-options:
  fast-import: add (non-)relative-marks feature
  fast-import: allow for multiple --import-marks= arguments
  fast-import: test the new option command
  fast-import: add option command
  fast-import: add feature command
  fast-import: put marks reading in its own function
  fast-import: put option parsing code in separate functions

11 years agoUpdate COPYING with GPLv2 with new FSF address
Junio C Hamano [Sat, 16 Jan 2010 05:38:34 +0000 (21:38 -0800)]
Update COPYING with GPLv2 with new FSF address

The mailing address of FSF changed quite a while ago.  Also the expansion
of the acronym LGPL (which we don't use) is "Lesser GPL" not "Library GPL"
these days in recent copies of GPLv2.  Update the copy we have with a
fresh download of <http://www.gnu.org/licenses/gpl-2.0.txt>.

This incidentally removes form-feeds in the text we retained for all these
years.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoDo not use date.c:tm_to_time_t() from compat/mingw.c
Johannes Sixt [Fri, 15 Jan 2010 20:12:21 +0000 (21:12 +0100)]
Do not use date.c:tm_to_time_t() from compat/mingw.c

To implement gettimeofday(), a broken-down UTC time was requested from the
system using GetSystemTime(), then tm_to_time_t() was used to convert it
to a time_t because it does not look at the current timezone, which
mktime() would do.

Use GetSystemTimeAsFileTime() and a different conversion path to avoid this
back-reference from the compatibility layer to the generic code.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMSVC: Windows-native implementation for subset of Pthreads API
Andrzej K. Haczewski [Fri, 15 Jan 2010 20:12:20 +0000 (21:12 +0100)]
MSVC: Windows-native implementation for subset of Pthreads API

This patch implements native to Windows subset of pthreads API used by Git.
It allows to remove Pthreads for Win32 dependency for MSVC, msysgit and
Cygwin.

[J6t: If the MinGW build was built as part of the msysgit build
environment, then threading was already enabled because the
pthreads-win32 package is available in msysgit. With this patch, we can now
enable threaded code unconditionally.]

Signed-off-by: Andrzej K. Haczewski <ahaczewski@gmail.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'maint'
Junio C Hamano [Sun, 17 Jan 2010 01:30:18 +0000 (17:30 -0800)]
Merge branch 'maint'

* maint:
  Fix uninitialized variable in get_refs_via_rsync().
  Document git-blame triple -C option

11 years agoMerge branch 'cc/reset-more'
Junio C Hamano [Sun, 17 Jan 2010 01:18:01 +0000 (17:18 -0800)]
Merge branch 'cc/reset-more'

* cc/reset-more:
  t7111: fix bad HEAD in tests with unmerged entries

11 years agoMSVC: Fix an "incompatible pointer types" compiler warning
Ramsay Jones [Fri, 15 Jan 2010 20:12:19 +0000 (21:12 +0100)]
MSVC: Fix an "incompatible pointer types" compiler warning

In particular, the following warning is issued while compiling
compat/msvc.c:

    ...mingw.c(223) : warning C4133: 'function' : incompatible \
types - from '_stati64 *' to '_stat64 *'

which relates to a call of _fstati64() in the mingw_fstat()
function definition.

This is caused by various layers of macro magic and attempts to
avoid macro redefinition compiler warnings. For example, the call
to _fstati64() mentioned above is actually a call to _fstat64(),
and expects a pointer to a struct _stat64 rather than the struct
_stati64 which is passed to mingw_fstat().

The definition of struct _stati64 given in compat/msvc.h had the
same "shape" as the definition of struct _stat64, so the call to
_fstat64() does not actually cause any runtime errors, but the
structure types are indeed incompatible.

In order to avoid the compiler warning, we add declarations for the
mingw_lstat() and mingw_fstat() functions and supporting macros to
msvc.h, suppressing the corresponding declarations in mingw.h, so
that we can use the appropriate structure type (and function) names
from the msvc headers.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoWindows: avoid the "dup dance" when spawning a child process
Johannes Sixt [Fri, 15 Jan 2010 20:12:18 +0000 (21:12 +0100)]
Windows: avoid the "dup dance" when spawning a child process

When stdin, stdout, or stderr must be redirected for a child process that
on Windows is spawned using one of the spawn() functions of Microsoft's
C runtime, then there is no choice other than to

1. make a backup copy of fd 0,1,2 with dup
2. dup2 the redirection source fd into 0,1,2
3. spawn
4. dup2 the backup back into 0,1,2
5. close the backup copy and the redirection source

We used this idiom as well -- but we are not using the spawn() functions
anymore!

Instead, we have our own implementation. We had hardcoded that stdin,
stdout, and stderr of the child process were inherited from the parent's
fds 0, 1, and 2. But we can actually specify any fd.

With this patch, the fds to inherit are passed from start_command()'s
WIN32 section to our spawn implementation. This way, we can avoid the
backup copies of the fds.

The backup copies were a bug waiting to surface: The OS handles underlying
the dup()ed fds were inherited by the child process (but were not
associated with a file descriptor in the child). Consequently, the file or
pipe represented by the OS handle remained open even after the backup copy
was closed in the parent process until the child exited.

Since our implementation of pipe() creates non-inheritable OS handles, we
still dup() file descriptors in start_command() because dup() happens to
create inheritable duplicates. (A nice side effect is that the fd cleanup
in start_command is the same for Windows and Unix and remains unchanged.)

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoWindows: simplify the pipe(2) implementation
Johannes Sixt [Fri, 15 Jan 2010 20:12:17 +0000 (21:12 +0100)]
Windows: simplify the pipe(2) implementation

Our implementation of pipe() must create non-inheritable handles for the
reason that when a child process is started, there is no opportunity to
close the unneeded pipe ends in the child (on POSIX this is done between
fork() and exec()).

Previously, we used the _pipe() function provided by Microsoft's C runtime
(which creates inheritable handles) and then turned the handles into
non-inheritable handles using the DuplicateHandle() API.

Simplify the procedure by using the CreatePipe() API, which can create
non-inheritable handles right from the beginning.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoWindows: boost startup by avoiding a static dependency on shell32.dll
Johannes Sixt [Fri, 15 Jan 2010 20:12:16 +0000 (21:12 +0100)]
Windows: boost startup by avoiding a static dependency on shell32.dll

This DLL is only needed to invoke the browser in a "git help" call. By
looking up the only function that we need at runtime, we can avoid the
startup costs of this DLL.

DLL usage can be profiled with Microsoft's Dependency Walker. For example,
a call to "git diff-files" loaded

before:  19 DLLs
after:    9 DLLs

As a result, the runtime of 'make -j2 test' went down from 16:00min
to 12:40min on one of my boxes.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoWindows: disable Python
Erik Faye-Lund [Fri, 15 Jan 2010 20:12:15 +0000 (21:12 +0100)]
Windows: disable Python

Python is not commonly installed on Windows machines, so
we should disable it there by default.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot7111: fix bad HEAD in tests with unmerged entries
Christian Couder [Sat, 16 Jan 2010 09:20:26 +0000 (10:20 +0100)]
t7111: fix bad HEAD in tests with unmerged entries

When testing what happens on unmerged entries, the HEAD is the
commit we are starting from before the merge that fails and create
the unmerged entries. It is not the commit before.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoFix uninitialized variable in get_refs_via_rsync().
Richard Weinberger [Thu, 14 Jan 2010 23:28:59 +0000 (00:28 +0100)]
Fix uninitialized variable in get_refs_via_rsync().

This fixes a crash when cloning via rsync://.

Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoTest t5560: Fix test when run with dash
Tarmigan Casebolt [Fri, 15 Jan 2010 06:44:02 +0000 (22:44 -0800)]
Test t5560: Fix test when run with dash

A command invocation preceded by variable assignments, i.e.

VAR1=VAL1 VAR2=VAL2 ... command args

are implemented by dash and ksh in such a way not to export these
variables, and keep the values after the command finishes, when the
command is a shell function.  POSIX.1 "2.9.5 Function Definition Command"
specifies this behaviour.

Many shells however treat this construct the same way as they are calling
external commands.  They export the variables during the duration of
command, and resets their values after command returns.

The test relied on the behaviour of the latter kind.

Reported-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoDocument git-blame triple -C option
Ramkumar Ramachandra [Fri, 8 Jan 2010 18:48:07 +0000 (00:18 +0530)]
Document git-blame triple -C option

Lift the explanation of -CCC option in the source to the documentation.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'jc/checkout-merge-base'
Junio C Hamano [Wed, 13 Jan 2010 20:31:13 +0000 (12:31 -0800)]
Merge branch 'jc/checkout-merge-base'

* jc/checkout-merge-base:
  rebase -i: teach --onto A...B syntax
  rebase: fix --onto A...B parsing and add tests
  "rebase --onto A...B" replays history on the merge base between A and B
  "checkout A...B" switches to the merge base between A and B

11 years agoMerge branch 'rs/maint-archive-match-pathspec'
Junio C Hamano [Wed, 13 Jan 2010 20:31:01 +0000 (12:31 -0800)]
Merge branch 'rs/maint-archive-match-pathspec'

* rs/maint-archive-match-pathspec:
  archive: complain about path specs that don't match anything

11 years agoMerge branch 'il/vcs-helper'
Junio C Hamano [Wed, 13 Jan 2010 20:30:39 +0000 (12:30 -0800)]
Merge branch 'il/vcs-helper'

* il/vcs-helper:
  Reset possible helper before reusing remote structure
  Remove special casing of http, https and ftp
  Support remote archive from all smart transports
  Support remote helpers implementing smart transports
  Support taking over transports
  Refactor git transport options parsing
  Pass unknown protocols to external protocol handlers
  Support mandatory capabilities
  Add remote helper debug mode

Conflicts:
Documentation/git-remote-helpers.txt
transport-helper.c

11 years agoMerge branch 'cc/reset-more'
Junio C Hamano [Wed, 13 Jan 2010 19:58:56 +0000 (11:58 -0800)]
Merge branch 'cc/reset-more'

* cc/reset-more:
  t7111: check that reset options work as described in the tables
  Documentation: reset: add some missing tables
  Fix bit assignment for CE_CONFLICTED
  "reset --merge": fix unmerged case
  reset: use "unpack_trees()" directly instead of "git read-tree"
  reset: add a few tests for "git reset --merge"
  Documentation: reset: add some tables to describe the different options
  reset: improve mixed reset error message when in a bare repo

11 years agoMerge branch 'nd/sparse'
Junio C Hamano [Wed, 13 Jan 2010 19:58:34 +0000 (11:58 -0800)]
Merge branch 'nd/sparse'

* nd/sparse: (25 commits)
  t7002: test for not using external grep on skip-worktree paths
  t7002: set test prerequisite "external-grep" if supported
  grep: do not do external grep on skip-worktree entries
  commit: correctly respect skip-worktree bit
  ie_match_stat(): do not ignore skip-worktree bit with CE_MATCH_IGNORE_VALID
  tests: rename duplicate t1009
  sparse checkout: inhibit empty worktree
  Add tests for sparse checkout
  read-tree: add --no-sparse-checkout to disable sparse checkout support
  unpack-trees(): ignore worktree check outside checkout area
  unpack_trees(): apply $GIT_DIR/info/sparse-checkout to the final index
  unpack-trees(): "enable" sparse checkout and load $GIT_DIR/info/sparse-checkout
  unpack-trees.c: generalize verify_* functions
  unpack-trees(): add CE_WT_REMOVE to remove on worktree alone
  Introduce "sparse checkout"
  dir.c: export excluded_1() and add_excludes_from_file_1()
  excluded_1(): support exclude files in index
  unpack-trees(): carry skip-worktree bit over in merged_entry()
  Read .gitignore from index if it is skip-worktree
  Avoid writing to buffer in add_excludes_from_file_1()
  ...

Conflicts:
.gitignore
Documentation/config.txt
Documentation/git-update-index.txt
Makefile
entry.c
t/t7002-grep.sh

11 years agot7502: test commit.status, --status and --no-status
Junio C Hamano [Wed, 13 Jan 2010 08:12:54 +0000 (00:12 -0800)]
t7502: test commit.status, --status and --no-status

Make sure that the status information:

 - is shown as before without configuration nor command line option;

 - is shown if commit.status is set to true and no command line option
   is given, or --status is explicitly given;

 - is not shown if commit.status is set to false and no command line
   option is given, or --no-status is explicitly given.

Also make sure that the way lines taken from the custom --template appear
in the log message editor is not changed at all.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agocommit: support commit.status, --status, and --no-status
James P. Howard, II [Mon, 7 Dec 2009 22:45:27 +0000 (17:45 -0500)]
commit: support commit.status, --status, and --no-status

A new configuration variable commit.status, and new command line
options --status, and --no-status control whether or not the git
status information is included in the commit message template
when using an editor to prepare the commit message.  It does not
affect the effects of a user's commit.template settings.

Signed-off-by: James P. Howard, II <jh@jameshoward.us>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'maint'
Junio C Hamano [Tue, 12 Jan 2010 23:48:38 +0000 (15:48 -0800)]
Merge branch 'maint'

* maint:
  remote-curl: Fix Accept header for smart HTTP connections
  grep: -L should show empty files
  rebase--interactive: Ignore comments and blank lines in peek_next_command

11 years agolockfile: show absolute filename in unable_to_lock_message
Matthieu Moy [Thu, 7 Jan 2010 14:54:10 +0000 (15:54 +0100)]
lockfile: show absolute filename in unable_to_lock_message

When calling a git command from a subdirectory and a file locking fails,
the user will get a path relative to the root of the worktree, which is
invalid from the place where the command is ran. Make it easy for the
user to know which file it is.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agohg-to-git: fix COMMITTER type-o
Bart Trojanowski [Sat, 9 Jan 2010 00:54:39 +0000 (19:54 -0500)]
hg-to-git: fix COMMITTER type-o

This script passes the author and committer to git-commit via environment
variables, but it was missing the seccond T of COMMITTER in a few places.

Signed-off-by: Bart Trojanowski <bart@jukie.net>
Acked-by: Stelian Pop <stelian@popies.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoremote-curl: Fix Accept header for smart HTTP connections
Shawn O. Pearce [Tue, 12 Jan 2010 17:54:04 +0000 (09:54 -0800)]
remote-curl: Fix Accept header for smart HTTP connections

We actually expect to see an application/x-git-upload-pack-result
but we lied and said we Accept *-response.  This was a typo on my
part when I was writing the code.

Fortunately the wrong Accept header had no real impact, as the
deployed git-http-backend servers were not testing the Accept
header before they returned their content.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agogrep: -L should show empty files
Junio C Hamano [Tue, 12 Jan 2010 08:22:23 +0000 (00:22 -0800)]
grep: -L should show empty files

The -L (--files-without-match) option is supposed to show paths that
produced no matches.  When running the internal grep on work tree files,
however, we had an optimization to just return on zero-sized files,
without doing anything.

This optimization doesn't matter too much in practice (a tracked empty
file must be rare, or there is something wrong with your project); to
produce results consistent with GNU grep, we should stop the optimization
and show empty files as not having the given pattern.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agopush: spell 'Note about fast-forwards' section name correctly in error message.
Matthieu Moy [Mon, 11 Jan 2010 21:09:44 +0000 (22:09 +0100)]
push: spell 'Note about fast-forwards' section name correctly in error message.

The error message in case of non-fast forward points to 'git push
--help', but used to talk about a section 'non-fast-forward', while the
actual section name is 'Note about fast-forwards'.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agorebase--interactive: Ignore comments and blank lines in peek_next_command
Michael Haggerty [Mon, 11 Jan 2010 15:56:45 +0000 (16:56 +0100)]
rebase--interactive: Ignore comments and blank lines in peek_next_command

Previously, blank lines and/or comments within a series of
squash/fixup commands would confuse "git rebase -i" into thinking that
the series was finished.  It would therefore require the user to edit
the commit message for the squash/fixup commits seen so far.  Then,
after continuing, it would ask the user to edit the commit message
again.

Ignore comments and blank lines within a group of squash/fixup
commands, allowing them to be processed in one go.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoAdd missing #include to support TIOCGWINSZ on Solaris
Nguyễn Thái Ngọc Duy [Mon, 11 Jan 2010 10:41:01 +0000 (17:41 +0700)]
Add missing #include to support TIOCGWINSZ on Solaris

On Linux TIOCGWINSZ is defined somehwere in ioctl.h, which is already
included. On Solaris we also need to include termios.h. Without this
term_columns() in help.c will think TIOCGWINSZ is not supported and
always return 80 columns.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoRemove empty directories when checking out a commit with fewer submodules
Peter Collingbourne [Mon, 11 Jan 2010 02:59:54 +0000 (02:59 +0000)]
Remove empty directories when checking out a commit with fewer submodules

Change the unlink_entry function to use rmdir to remove submodule
directories.  Currently we try to use unlink, which will never succeed.

Of course rmdir will only succeed for empty (i.e. not checked out)
submodule directories.  Behaviour if a submodule is checked out stays
essentially the same: print a warning message and keep the submodule
directory.

Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'tr/http-updates'
Junio C Hamano [Sun, 10 Jan 2010 16:53:04 +0000 (08:53 -0800)]
Merge branch 'tr/http-updates'

* tr/http-updates:
  Remove http.authAny
  Allow curl to rewind the RPC read buffer
  Add an option for using any HTTP authentication scheme, not only basic
  http: maintain curl sessions

11 years agoMerge branch 'jk/maint-1.6.5-reset-hard'
Junio C Hamano [Sun, 10 Jan 2010 16:52:53 +0000 (08:52 -0800)]
Merge branch 'jk/maint-1.6.5-reset-hard'

* jk/maint-1.6.5-reset-hard:
  reset: unbreak hard resets with GIT_WORK_TREE

11 years agoMerge branch 'jk/push-to-delete'
Junio C Hamano [Sun, 10 Jan 2010 16:52:45 +0000 (08:52 -0800)]
Merge branch 'jk/push-to-delete'

* jk/push-to-delete:
  builtin-push: add --delete as syntactic sugar for :foo

11 years agoMerge branch 'mm/config-path'
Junio C Hamano [Sun, 10 Jan 2010 16:52:41 +0000 (08:52 -0800)]
Merge branch 'mm/config-path'

* mm/config-path:
  builtin-config: add --path option doing ~ and ~user expansion.

11 years agoMerge branch 'pm/cvs-environ'
Junio C Hamano [Sun, 10 Jan 2010 16:52:37 +0000 (08:52 -0800)]
Merge branch 'pm/cvs-environ'

* pm/cvs-environ:
  CVS Server: Support reading base and roots from environment

11 years agoMerge branch 'tr/maint-1.6.5-bash-prompt-show-submodule-changes'
Junio C Hamano [Sun, 10 Jan 2010 16:52:32 +0000 (08:52 -0800)]
Merge branch 'tr/maint-1.6.5-bash-prompt-show-submodule-changes'

* tr/maint-1.6.5-bash-prompt-show-submodule-changes:
  bash completion: factor submodules into dirty state

11 years agoMerge branch 'bg/maint-remote-update-default'
Junio C Hamano [Sun, 10 Jan 2010 16:52:24 +0000 (08:52 -0800)]
Merge branch 'bg/maint-remote-update-default'

* bg/maint-remote-update-default:
  Fix "git remote update" with remotes.defalt set

11 years agoMerge branch 'mm/diag-path-in-treeish'
Junio C Hamano [Sun, 10 Jan 2010 16:52:10 +0000 (08:52 -0800)]
Merge branch 'mm/diag-path-in-treeish'

* mm/diag-path-in-treeish:
  Detailed diagnosis when parsing an object name fails.

11 years agoMerge branch 'fc/opt-quiet-gc-reset'
Junio C Hamano [Sun, 10 Jan 2010 16:52:06 +0000 (08:52 -0800)]
Merge branch 'fc/opt-quiet-gc-reset'

* fc/opt-quiet-gc-reset:
  General --quiet improvements

11 years agoMerge branch 'maint'
Junio C Hamano [Sun, 10 Jan 2010 08:52:04 +0000 (00:52 -0800)]
Merge branch 'maint'

* maint:
  base85: Make the code more obvious instead of explaining the non-obvious
  base85: encode_85() does not use the decode table
  base85 debug code: Fix length byte calculation
  Documentation: tiny git config manual tweaks
  Documentation: git gc packs refs by default now
  checkout -m: do not try to fall back to --merge from an unborn branch

11 years agoMerge branch 'maint-1.6.2' into maint
Junio C Hamano [Sun, 10 Jan 2010 08:51:54 +0000 (00:51 -0800)]
Merge branch 'maint-1.6.2' into maint

* maint-1.6.2:
  base85: Make the code more obvious instead of explaining the non-obvious
  base85: encode_85() does not use the decode table
  base85 debug code: Fix length byte calculation
  checkout -m: do not try to fall back to --merge from an unborn branch

Conflicts:
diff.c

11 years agoMerge branch 'maint-1.6.1' into maint-1.6.2
Junio C Hamano [Sun, 10 Jan 2010 08:49:47 +0000 (00:49 -0800)]
Merge branch 'maint-1.6.1' into maint-1.6.2

* maint-1.6.1:
  base85: Make the code more obvious instead of explaining the non-obvious
  base85: encode_85() does not use the decode table
  base85 debug code: Fix length byte calculation
  checkout -m: do not try to fall back to --merge from an unborn branch
  branch: die explicitly why when calling "git branch [-a|-r] branchname".
  textconv: stop leaking file descriptors
  commit: --cleanup is a message option
  git count-objects: handle packs bigger than 4G
  t7102: make the test fail if one of its check fails

Conflicts:
diff.c

11 years agoMerge branch 'maint-1.6.0' into maint-1.6.1
Junio C Hamano [Sun, 10 Jan 2010 08:48:47 +0000 (00:48 -0800)]
Merge branch 'maint-1.6.0' into maint-1.6.1

* maint-1.6.0:
  base85: Make the code more obvious instead of explaining the non-obvious
  base85: encode_85() does not use the decode table
  base85 debug code: Fix length byte calculation
  checkout -m: do not try to fall back to --merge from an unborn branch
  branch: die explicitly why when calling "git branch [-a|-r] branchname".

11 years agodaemon: consider only address in kill_some_child()
Erik Faye-Lund [Sat, 9 Jan 2010 14:13:28 +0000 (15:13 +0100)]
daemon: consider only address in kill_some_child()

kill_some_child() compares the entire sockaddr_storage
structure (with the pad-bits zeroed out) when trying to
find out if connections originate from the same host.
However, sockaddr_storage contains the port-number for
the connection (which varies between connections), so
the comparison always fails.

Change the code so we only consider the host-address,
by introducing the addrcmp()-function that inspects
the address family and compare as appropriate.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agohelp: fix configured help format taking over command line one
Christian Couder [Sat, 9 Jan 2010 05:10:05 +0000 (06:10 +0100)]
help: fix configured help format taking over command line one

Since commit 7c3baa9 (help -a: do not unnecessarily look for a
repository, 2009-09-04), the help format that is passed as a
command line option is not used if an help format has been
configured. This patch fixes that.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agostring-list: rename the include guard to STRING_LIST_H
Thiago Farina [Fri, 8 Jan 2010 22:45:08 +0000 (17:45 -0500)]
string-list: rename the include guard to STRING_LIST_H

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot7111: check that reset options work as described in the tables
Christian Couder [Fri, 8 Jan 2010 04:45:10 +0000 (05:45 +0100)]
t7111: check that reset options work as described in the tables

Some previous patches added some tables to the "git reset"
documentation. These tables describe the behavior of "git reset"
depending on the option it is passed and the state of the files
in the working tree, the index, HEAD and the target commit.

This patch adds some tests to make sure that the tables describe
the behavior of "git reset".

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agobase85: Make the code more obvious instead of explaining the non-obvious
Andreas Gruenbacher [Fri, 8 Jan 2010 13:40:00 +0000 (14:40 +0100)]
base85: Make the code more obvious instead of explaining the non-obvious

Here is another cleanup ...

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agobase85: encode_85() does not use the decode table
Andreas Gruenbacher [Fri, 8 Jan 2010 16:22:18 +0000 (17:22 +0100)]
base85: encode_85() does not use the decode table

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agobase85 debug code: Fix length byte calculation
Andreas Gruenbacher [Fri, 8 Jan 2010 13:39:58 +0000 (14:39 +0100)]
base85 debug code: Fix length byte calculation

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoDocumentation: tiny git config manual tweaks
Jonathan Nieder [Sun, 10 Jan 2010 03:01:21 +0000 (21:01 -0600)]
Documentation: tiny git config manual tweaks

As a verb, 'setup' is spelled 'set up'.  “diff commands such as
diff-files” scans better without a comma.  Clarify that shallow
and deep are special non-boolean values for format.thread rather
than boolean values with some other name.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoDocumentation: git gc packs refs by default now
Jonathan Nieder [Sun, 10 Jan 2010 02:59:41 +0000 (20:59 -0600)]
Documentation: git gc packs refs by default now

In commit 56752391 (Make "git gc" pack all refs by default,
2007-05-24), 'git gc' was changed to run pack-refs by default

Versions before v1.5.1.2 cannot clone repos with packed refs over
http, and versions before v1.4.4 cannot handled packed refs at
all, but more recent git should have no problems.  Try to make
this more clear in the git-config manual.

The analagous passage in git-gc.txt was updated already with
commit fe2128a (Change git-gc documentation to reflect
gc.packrefs implementation., 2008-01-09).

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoReset possible helper before reusing remote structure
Ilari Liusvaara [Sat, 9 Jan 2010 17:28:12 +0000 (19:28 +0200)]
Reset possible helper before reusing remote structure

If one had multiple URLs configured for remote with previous one
having forced helper but the subsequent one not, like:

url = foo::bar://baz
url = ssh://example/example.git

Then the subsequent URL is passed to foo helper, which isn't
correct. Fix it to be parsed normally by resetting foreign VCS
name before parsing the URL protocol.

Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoDescribe second batch for 1.7.0 in draft release notes
Junio C Hamano [Thu, 7 Jan 2010 23:47:32 +0000 (15:47 -0800)]
Describe second batch for 1.7.0 in draft release notes

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'js/filter-branch-prime'
Junio C Hamano [Thu, 7 Jan 2010 23:40:30 +0000 (15:40 -0800)]
Merge branch 'js/filter-branch-prime'

* js/filter-branch-prime:
  filter-branch: remove an unnecessary use of 'git read-tree'

11 years agoMerge branch 'sb/maint-octopus'
Junio C Hamano [Thu, 7 Jan 2010 23:40:21 +0000 (15:40 -0800)]
Merge branch 'sb/maint-octopus'

* sb/maint-octopus:
  octopus: remove dead code
  octopus: reenable fast-forward merges
  octopus: make merge process simpler to follow

Conflicts:
git-merge-octopus.sh

11 years agoMerge branch 'mg/tag-d-show'
Junio C Hamano [Thu, 7 Jan 2010 23:38:50 +0000 (15:38 -0800)]
Merge branch 'mg/tag-d-show'

* mg/tag-d-show:
  tag -d: print sha1 of deleted tag

11 years agoMerge branch 'so/cvsserver-update'
Junio C Hamano [Thu, 7 Jan 2010 23:38:11 +0000 (15:38 -0800)]
Merge branch 'so/cvsserver-update'

* so/cvsserver-update:
  cvsserver: make the output of 'update' more compatible with cvs.

11 years agoMerge branch 'bg/maint-add-all-doc'
Junio C Hamano [Thu, 7 Jan 2010 23:37:57 +0000 (15:37 -0800)]
Merge branch 'bg/maint-add-all-doc'

* bg/maint-add-all-doc:
  git-rm doc: Describe how to sync index & work tree
  git-add/rm doc: Consistently back-quote
  Documentation: 'git add -A' can remove files

11 years agogit-rm doc: Describe how to sync index & work tree
Björn Gustavsson [Mon, 7 Dec 2009 18:35:42 +0000 (19:35 +0100)]
git-rm doc: Describe how to sync index & work tree

Newcomers to git that want to remove from the index only the
files that have disappeared from the working tree will probably
look for a way to do that in the documentation for 'git rm'.

Therefore, describe how that can be done (even though it involves
other commands than 'git rm'). Based on a suggestion by Junio,
but re-arranged and rewritten to better fit into the style of
command reference.

While at it, change a single occurrence of "work tree" to "working
tree" for consistency.

Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMerge branch 'mv/commit-date'
Junio C Hamano [Thu, 7 Jan 2010 23:35:55 +0000 (15:35 -0800)]
Merge branch 'mv/commit-date'

* mv/commit-date:
  Document date formats accepted by parse_date()
  builtin-commit: add --date option

11 years agoMerge branch 'mo/bin-wrappers'
Junio C Hamano [Thu, 7 Jan 2010 23:35:52 +0000 (15:35 -0800)]
Merge branch 'mo/bin-wrappers'

* mo/bin-wrappers:
  INSTALL: document a simpler way to run uninstalled builds
  run test suite without dashed git-commands in PATH
  build dashless "bin-wrappers" directory similar to installed bindir

11 years agorebase -i: teach --onto A...B syntax
Nanako Shiraishi [Thu, 7 Jan 2010 11:05:09 +0000 (20:05 +0900)]
rebase -i: teach --onto A...B syntax

When rewriting commits on a topic branch, sometimes it is easier to
compare the version of commits before and after the rewrite if they are
based on the same commit that forked from the upstream. An earlier commit
by Junio (fixed up by the previous commit) gives "--onto A...B" syntax to
rebase command, and rebases on top of the merge base between A and B;
teach the same to the interactive version, too.

Signed-off-by: しらいし ななこ <nanako3@lavabit.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agorebase: fix --onto A...B parsing and add tests
Nanako Shiraishi [Thu, 7 Jan 2010 11:05:02 +0000 (20:05 +0900)]
rebase: fix --onto A...B parsing and add tests

The previous patch didn't parse "rebase --onto A...B" correctly when A
isn't an empty string. It also tried to be careful to notice a case in
which there are more than one merge bases, but forgot to give --all option
to merge-base, making the test pointless.

Fix these problems and add a test script to verify. Improvements to the
script to parse A...B syntax was taken from review comments by Johannes
Schindelin.

Signed-off-by: しらいし ななこ <nanako3@lavabit.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agocheckout -m: do not try to fall back to --merge from an unborn branch
Junio C Hamano [Thu, 7 Jan 2010 07:51:47 +0000 (23:51 -0800)]
checkout -m: do not try to fall back to --merge from an unborn branch

If switching from an unborn branch (= empty tree) to a valid commit failed
without -m, it would fail with -m option as well.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot7002: test for not using external grep on skip-worktree paths
Nguyễn Thái Ngọc Duy [Mon, 4 Jan 2010 12:34:15 +0000 (19:34 +0700)]
t7002: test for not using external grep on skip-worktree paths

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot7002: set test prerequisite "external-grep" if supported
Nguyễn Thái Ngọc Duy [Mon, 4 Jan 2010 12:34:14 +0000 (19:34 +0700)]
t7002: set test prerequisite "external-grep" if supported

Add another test to set prerequisite EXTGREP if the current build supports
external grep. This can be used to skip external grep only tests on builds
that do not support this optimization.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agocheckout -m path: fix recreating conflicts
Junio C Hamano [Wed, 6 Jan 2010 20:32:02 +0000 (12:32 -0800)]
checkout -m path: fix recreating conflicts

We should tell ll_merge() that the 3-way merge between stages #2 and #3 is
an outermost merge, not a virtual-ancestor creation.

Back when this code was originally written, users couldn't write custom
merge drivers easily, so the bug didn't matter, but these days it does.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years ago.gitattributes: detect 8-space indent in shell scripts
Junio C Hamano [Wed, 6 Jan 2010 20:22:25 +0000 (12:22 -0800)]
.gitattributes: detect 8-space indent in shell scripts

Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMakefile: consolidate .FORCE-* targets
Jonathan Nieder [Wed, 6 Jan 2010 08:06:58 +0000 (02:06 -0600)]
Makefile: consolidate .FORCE-* targets

Providing multiple targets to force a rebuild is unnecessary
complication.

Avoid using a name that could conflict with future special
targets in GNU make (a leading period followed by uppercase
letters).

The corresponding change to the git-gui Makefile is left for
another patch.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMakefile: learn to generate listings for targets requiring special flags
Jonathan Nieder [Wed, 6 Jan 2010 08:06:03 +0000 (02:06 -0600)]
Makefile: learn to generate listings for targets requiring special flags

'make git.s' to debug code generation of main() fails because
git.c makes use of preprocessor symbols such as GIT_VERSION that
are not set.  make does not generate code listings for
builtin_help.c, exec_cmd.c, builtin-init-db.c, config.c, http.c,
or http-walker.c either, for the same reason.

So pass the flags used to generate each .o file when generating
the corresponding assembler listing.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMakefile: use target-specific variable to pass flags to cc
Jonathan Nieder [Wed, 6 Jan 2010 08:05:04 +0000 (02:05 -0600)]
Makefile: use target-specific variable to pass flags to cc

This allows reusing the standard %.o: %.c pattern rule even for
targets that require special flags to be set.  Thus after this
change, any changes in the command for compilation only have to
be performed in one place.

Target-specific variables have been supported in GNU make since
version 3.77, which has been available since 1998.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMakefile: regenerate assembler listings when asked
Jonathan Nieder [Wed, 6 Jan 2010 08:04:20 +0000 (02:04 -0600)]
Makefile: regenerate assembler listings when asked

'make var.s' fails to regenerate an assembler listing if var.c
has not changed but a header it includes has:

$ make var.s
    CC var.s
$ touch cache.h
$ make var.s
$

The corresponding problem for 'make var.o' does not occur because
the Makefile lists dependencies for each .o target explicitly;
analogous dependency rules for the .s targets are not present.
Rather than add some, it seems better to force 'make' to always
regenerate assembler listings, since the assembler listing
targets are only invoked when specifically requested on the make
command line.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoSmart-http tests: Test http-backend without curl or a webserver
Tarmigan Casebolt [Sat, 2 Jan 2010 21:43:59 +0000 (13:43 -0800)]
Smart-http tests: Test http-backend without curl or a webserver

This reuses many of the tests from the old t5560 but runs those tests
without curl or a webserver.  This will hopefully increase the testing
coverage for http-backend because it does not require users to set
GIT_TEST_HTTPD.

Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoSmart-http tests: Break test t5560-http-backend into pieces
Tarmigan Casebolt [Sat, 2 Jan 2010 21:38:06 +0000 (13:38 -0800)]
Smart-http tests: Break test t5560-http-backend into pieces

This should introduce no functional change in the tests or the amount
of test coverage.

Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoSmart-http tests: Improve coverage in test t5560
Tarmigan Casebolt [Sat, 2 Jan 2010 21:38:05 +0000 (13:38 -0800)]
Smart-http tests: Improve coverage in test t5560

Commit 34b6cb8bb ("http-backend: Protect GIT_PROJECT_ROOT from /../
requests") added the path_info helper function to test t5560 but did
not use it.  We should use it as it provides another level of error
checking.

The /etc/.../passwd case is one that is not special (and the test
fails for reasons other than being aliased), so we remove that test
case.

Also rename the function from 'path_info' to 'expect_aliased'.

Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoSmart-http: check if repository is OK to export before serving it
Tarmigan Casebolt [Mon, 28 Dec 2009 21:49:00 +0000 (16:49 -0500)]
Smart-http: check if repository is OK to export before serving it

Similar to how git-daemon checks whether a repository is OK to be
exported, smart-http should also check.  This check can be satisfied
in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
may be set to export all repositories, or the individual repository
may have the file git-daemon-export-ok.

Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot/lib-http.sh: Restructure finding of default httpd location
Tarmigan Casebolt [Sat, 2 Jan 2010 22:04:25 +0000 (14:04 -0800)]
t/lib-http.sh: Restructure finding of default httpd location

On CentOS 5, httpd is located at /usr/sbin/httpd, and the modules are
located at /usr/lib64/httpd/modules.  To enable easy testing of httpd,
we would like those locations to be detected automatically.

uname might not be the best way to determine the default location for
httpd since different Linux distributions apparently put httpd in
different places, so we test a couple different locations for httpd,
and use the first one that we come across.  We do the same for the
modules directory.

cc: Jay Soffian <jaysoffian@gmail.com>
Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot4030, t4031: work around bogus MSYS bash path conversion
Johannes Sixt [Fri, 1 Jan 2010 22:15:18 +0000 (23:15 +0100)]
t4030, t4031: work around bogus MSYS bash path conversion

Recall that MSYS bash converts POSIX style absolute paths to Windows style
absolute paths. Unfortunately, it converts a program argument that begins
with a double-quote and otherwise looks like an absolute POSIX path, but
in doing so, it strips everything past the second double-quote[*]. This
case is triggered in the two test scripts. The work-around is to place the
Windows style path returned by $(pwd) between the quotes to avoid the path
conversion.

[*] It is already bogus that a conversion is even considered when a program
argument begins with a double-quote because it cannot be an absolute POSIX
path.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agodiff: run external diff helper with shell
Jeff King [Wed, 30 Dec 2009 11:03:35 +0000 (06:03 -0500)]
diff: run external diff helper with shell

This is mostly to make it more consistent with the rest of
git, which uses the shell to exec helpers.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agotextconv: use shell to run helper
Jeff King [Wed, 30 Dec 2009 11:01:09 +0000 (06:01 -0500)]
textconv: use shell to run helper

Currently textconv helpers are run directly. Running through
the shell is useful because the user can provide a program
with command line arguments, like "antiword -f".

It also makes textconv more consistent with other parts of
git, most of which run their helpers using the shell.

The downside is that textconv helpers with shell
metacharacters (like space) in the filename will be broken.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoeditor: use run_command's shell feature
Jeff King [Wed, 30 Dec 2009 10:56:16 +0000 (05:56 -0500)]
editor: use run_command's shell feature

Now that run_command implements the same code in a more
general form, we can make use of it.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agorun-command: optimize out useless shell calls
Jeff King [Wed, 30 Dec 2009 10:55:36 +0000 (05:55 -0500)]
run-command: optimize out useless shell calls

If there are no metacharacters in the program to be run, we
can just skip running the shell entirely and directly exec
the program.

The metacharacter test is pulled verbatim from
launch_editor, which already implements this optimization.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agorun-command: convert simple callsites to use_shell
Jeff King [Wed, 30 Dec 2009 10:53:57 +0000 (05:53 -0500)]
run-command: convert simple callsites to use_shell

Now that we have the use_shell feature, these callsites can
all be converted with small changes.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agot0021: use $SHELL_PATH for the filter script
Johannes Sixt [Fri, 1 Jan 2010 22:14:06 +0000 (23:14 +0100)]
t0021: use $SHELL_PATH for the filter script

On Windows, we need the shbang line to correctly invoke shell scripts via
a POSIX shell, except when the script is invoked via 'sh -c' because sh (a
bash) does "the right thing".  But the clean and smudge filters will not
always be invoked via 'sh -c'; to futureproof, we should mark the the one
in t0021-conversion with #!$SHELL_PATH.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoMakefile: make ppc/sha1ppc.o depend on GIT-CFLAGS
Jonathan Nieder [Wed, 6 Jan 2010 06:37:59 +0000 (00:37 -0600)]
Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGS

The %.o: %.S pattern rule should depend on GIT-CFLAGS to avoid
trouble when ALL_CFLAGS changes.

The pattern only applies to one file (ppc/sha1ppc.S) and that
file does not use any #ifdefs, so leaving the dependency out is
probably harmless.  Nevertheless, it is safer to include the
dependency in case future code's behavior does depend on the
build flags.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoDocumentation: reset: add some missing tables
Christian Couder [Tue, 5 Jan 2010 05:58:30 +0000 (06:58 +0100)]
Documentation: reset: add some missing tables

and while at it also explain why --merge option is disallowed in some
cases.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
11 years agoFix bit assignment for CE_CONFLICTED
Junio C Hamano [Mon, 4 Jan 2010 08:02:00 +0000 (00:02 -0800)]
Fix bit assignment for CE_CONFLICTED

CE_WT_REMOVE has already grabbed the same value.

Signed-off-by: Junio C Hamano <gitster@pobox.com>