promisor-remote: parse remote.*.partialclonefilter
authorChristian Couder <christian.couder@gmail.com>
Tue, 25 Jun 2019 13:40:32 +0000 (15:40 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 25 Jun 2019 21:05:37 +0000 (14:05 -0700)
This makes it possible to specify a different partial clone
filter for each promisor remote.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fetch.c
list-objects-filter-options.c
list-objects-filter-options.h
promisor-remote.c
promisor-remote.h
t/t0410-partial-clone.sh
t/t5601-clone.sh
t/t5616-partial-clone.sh

index f74bd78..13d8133 100644 (file)
@@ -1491,7 +1491,7 @@ static inline void fetch_one_setup_partial(struct remote *remote)
         * the config.
         */
        if (!filter_options.choice)
-               partial_clone_get_default_filter_spec(&filter_options);
+               partial_clone_get_default_filter_spec(&filter_options, remote->name);
        return;
 }
 
index b0de7d3..28c571f 100644 (file)
@@ -30,6 +30,9 @@ static int gently_parse_list_objects_filter(
 {
        const char *v0;
 
+       if (!arg)
+               return 0;
+
        if (filter_options->choice) {
                if (errbuf) {
                        strbuf_addstr(
@@ -148,6 +151,7 @@ void partial_clone_register(
        const struct list_objects_filter_options *filter_options)
 {
        char *cfg_name;
+       char *filter_name;
 
        /* Check if it is already registered */
        if (!promisor_remote_find(remote)) {
@@ -162,27 +166,26 @@ void partial_clone_register(
        /*
         * Record the initial filter-spec in the config as
         * the default for subsequent fetches from this remote.
-        *
-        * TODO: record it into remote.<name>.partialclonefilter
         */
-       core_partial_clone_filter_default =
-               xstrdup(filter_options->filter_spec);
-       git_config_set("core.partialclonefilter",
-                      core_partial_clone_filter_default);
+       filter_name = xstrfmt("remote.%s.partialclonefilter", remote);
+       git_config_set(filter_name, filter_options->filter_spec);
+       free(filter_name);
 
        /* Make sure the config info are reset */
        promisor_remote_reinit();
 }
 
 void partial_clone_get_default_filter_spec(
-       struct list_objects_filter_options *filter_options)
+       struct list_objects_filter_options *filter_options,
+       const char *remote)
 {
+       struct promisor_remote *promisor = promisor_remote_find(remote);
+
        /*
         * Parse default value, but silently ignore it if it is invalid.
         */
-       if (!core_partial_clone_filter_default)
-               return;
-       gently_parse_list_objects_filter(filter_options,
-                                        core_partial_clone_filter_default,
-                                        NULL);
+       if (promisor)
+               gently_parse_list_objects_filter(filter_options,
+                                                promisor->partial_clone_filter,
+                                                NULL);
 }
index c54f000..8deaa28 100644 (file)
@@ -87,6 +87,7 @@ void partial_clone_register(
        const char *remote,
        const struct list_objects_filter_options *filter_options);
 void partial_clone_get_default_filter_spec(
-       struct list_objects_filter_options *filter_options);
+       struct list_objects_filter_options *filter_options,
+       const char *remote);
 
 #endif /* LIST_OBJECTS_FILTER_OPTIONS_H */
index 6a8856f..826890f 100644 (file)
@@ -75,6 +75,21 @@ static int promisor_remote_config(const char *var, const char *value, void *data
                free(remote_name);
                return 0;
        }
+       if (!strcmp(subkey, "partialclonefilter")) {
+               struct promisor_remote *r;
+               char *remote_name = xmemdupz(name, namelen);
+
+               r = promisor_remote_lookup(remote_name, NULL);
+               if (!r)
+                       r = promisor_remote_new(remote_name);
+
+               free(remote_name);
+
+               if (!r)
+                       return 0;
+
+               return git_config_string(&r->partial_clone_filter, var, value);
+       }
 
        return 0;
 }
index dddd404..838cb09 100644 (file)
@@ -5,10 +5,13 @@ struct object_id;
 
 /*
  * Promisor remote linked list
- * Its information come from remote.XXX config entries.
+ *
+ * Information in its fields come from remote.XXX config entries or
+ * from extensions.partialclone or core.partialclonefilter.
  */
 struct promisor_remote {
        struct promisor_remote *next;
+       const char *partial_clone_filter;
        const char name[FLEX_ARRAY];
 };
 
index 3559313..3082eff 100755 (executable)
@@ -26,7 +26,7 @@ promise_and_delete () {
 test_expect_success 'extensions.partialclone without filter' '
        test_create_repo server &&
        git clone --filter="blob:none" "file://$(pwd)/server" client &&
-       git -C client config --unset core.partialclonefilter &&
+       git -C client config --unset remote.origin.partialclonefilter &&
        git -C client fetch origin
 '
 
index 534d03a..078cf48 100755 (executable)
@@ -655,6 +655,7 @@ partial_clone () {
 
        # Ensure that unneeded blobs are not inadvertently fetched.
        test_config -C client remote.origin.promisor "false" &&
+       git -C client config --unset remote.origin.partialclonefilter &&
        test_must_fail git -C client cat-file -e "$HASH1" &&
 
        # But this blob was fetched, because clone performs an initial checkout
index 8f9a62a..8ae7ba9 100755 (executable)
@@ -43,7 +43,7 @@ test_expect_success 'do partial clone 1' '
        test_cmp expect_1.oids observed.oids &&
        test "$(git -C pc1 config --local core.repositoryformatversion)" = "1" &&
        test "$(git -C pc1 config --local remote.origin.promisor)" = "true" &&
-       test "$(git -C pc1 config --local core.partialclonefilter)" = "blob:none"
+       test "$(git -C pc1 config --local remote.origin.partialclonefilter)" = "blob:none"
 '
 
 # checkout master to force dynamic object fetch of blobs at HEAD.