t3900: add some more quotes
authorBeat Bolli <dev+git@drbeat.li>
Wed, 10 Jan 2018 09:58:32 +0000 (10:58 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 10 Jan 2018 23:07:26 +0000 (15:07 -0800)
In 89a70b80 ("t0302 & t3900: add forgotten quotes", 2018-01-03), quotes
were added to protect against spaces in $HOME. In the test_when_finished
command, two files are deleted which must be quoted individually.

[jc: with \$HOME in the test_when_finished command quoted, as
pointed out by j6t].

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Helped-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t3900-i18n-commit.sh

index 9e4e694..b92ff95 100755 (executable)
@@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' '
 '
 
 test_expect_success 'UTF-8 invalid characters refused' '
-       test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
+       test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\"" &&
        echo "UTF-8 characters" >F &&
        printf "Commit message\n\nInvalid surrogate:\355\240\200\n" \
                >"$HOME/invalid" &&
@@ -49,7 +49,7 @@ test_expect_success 'UTF-8 invalid characters refused' '
 '
 
 test_expect_success 'UTF-8 overlong sequences rejected' '
-       test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
+       test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\"" &&
        rm -f "$HOME/stderr" "$HOME/invalid" &&
        echo "UTF-8 overlong" >F &&
        printf "\340\202\251ommit message\n\nThis is not a space:\300\240\n" \
@@ -59,7 +59,7 @@ test_expect_success 'UTF-8 overlong sequences rejected' '
 '
 
 test_expect_success 'UTF-8 non-characters refused' '
-       test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
+       test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\"" &&
        echo "UTF-8 non-character 1" >F &&
        printf "Commit message\n\nNon-character:\364\217\277\276\n" \
                >"$HOME/invalid" &&
@@ -68,7 +68,7 @@ test_expect_success 'UTF-8 non-characters refused' '
 '
 
 test_expect_success 'UTF-8 non-characters refused' '
-       test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
+       test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\"" &&
        echo "UTF-8 non-character 2." >F &&
        printf "Commit message\n\nNon-character:\357\267\220\n" \
                >"$HOME/invalid" &&