Remove unnecessary debugging from builtin-fetch
authorShawn O. Pearce <spearce@spearce.org>
Fri, 14 Sep 2007 07:31:11 +0000 (03:31 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 19 Sep 2007 10:22:30 +0000 (03:22 -0700)
The older git-fetch client did not produce all of this debugging
information to stdout.  Most end-users and Porcelain (e.g. StGIT,
git-gui, qgit) do not want to see these low-level details on the
console so they should be removed.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-fetch-pack.c
builtin-fetch.c

index 3b217d9..e77cd26 100644 (file)
@@ -767,8 +767,6 @@ struct ref *fetch_pack(const char *dest, int nr_heads, char **heads)
                        st.st_mtime = 0;
        }
 
-       printf("connect to %s\n", dest);
-
        pid = git_connect(fd, (char *)dest, uploadpack,
                           verbose ? CONNECT_VERBOSE : 0);
        if (pid < 0)
index 016c6e4..33b740c 100644 (file)
@@ -370,15 +370,6 @@ static int do_fetch(struct transport *transport,
        for (rm = ref_map; rm; rm = rm->next) {
                if (rm->peer_ref)
                        read_ref(rm->peer_ref->name, rm->peer_ref->old_sha1);
-
-               printf("%s : %s\n", rm->name, rm->peer_ref ? rm->peer_ref->name : NULL);
-               printf("  < %s\n", sha1_to_hex(rm->old_sha1));
-               if (rm->peer_ref)
-                       printf("  > %s\n", sha1_to_hex(rm->peer_ref->old_sha1));
-               if (!rm->peer_ref ||
-                   hashcmp(rm->old_sha1, rm->peer_ref->old_sha1)) {
-                       printf("%s needs update.\n", rm->name);
-               }
        }
 
        if (fetch_refs(transport, ref_map)) {