builtin: consistently pass cmd_* prefix to parse_options
authorJeff King <peff@peff.net>
Thu, 9 May 2019 21:28:51 +0000 (17:28 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 13 May 2019 05:22:53 +0000 (14:22 +0900)
commitd64db5b334f8822284bcc7068e093d8fbfb46dd9
treeb5280ca93f5844b496f508730791c3ce37664292
parent76a7bc092efc2be59f1e42dc437154a9a1feed0a
builtin: consistently pass cmd_* prefix to parse_options

If a builtin uses RUN_SETUP to request that git.c enter the repository
directory, we'll get passed in a "prefix" variable with the path to the
original directory.  It's important to pass this to parse_options(),
since we may use it to fix up relative OPT_FILENAME() options. Some
builtins don't bother; let's make sure we do so consistently.

There may not be any particular bugs fixed here; OPT_FILENAME is
actually pretty rare, and none of these commands use it directly.
However, this does future-proof us against somebody adding an option
that uses it and creating a subtle bug that only shows up when you're in
a subdirectory of the repository.

In some cases, like hash-object and upload-pack, we don't specify
RUN_SETUP, so we know the prefix will always be empty. It's still worth
passing the variable along to keep the idiom consistent across all
builtins (and of course it protects us if they ever _did_ switch to
using RUN_SETUP).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/column.c
builtin/hash-object.c
builtin/range-diff.c
builtin/rebase--interactive.c
builtin/upload-pack.c