list-objects-filter-options: make filter_spec a string_list
authorMatthew DeVore <matvore@google.com>
Thu, 27 Jun 2019 22:54:10 +0000 (15:54 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 28 Jun 2019 15:41:53 +0000 (08:41 -0700)
commitcf9ceb5a12cad9c9153d227a0f497d1b522ce085
treec44af4360522bd6fb3e7683eae387b24cd90e5a8
parentf56f764279be2433ecf3cb3a484210bcaffea70c
list-objects-filter-options: make filter_spec a string_list

Make the filter_spec string a string_list rather than a raw C string.
The list of strings must be concatted together to make a complete
filter_spec. A future patch will use this capability to build "combine:"
filter specs gradually.

A strbuf would seem to be a more natural choice for this object, but it
unfortunately requires initialization besides just zero'ing out the
memory.  This results in all container structs, and all containers of
those structs, etc., to also require initialization. Initializing them
all would be more cumbersome that simply using a string_list, which
behaves properly when its contents are zero'd.

For the purposes of code simplification, change behavior in how filter
specs are conveyed over the protocol: do not normalize the tree:<depth>
filter specs since there should be no server in existence that supports
tree:# but not tree:#k etc.

Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/clone.c
builtin/fetch.c
builtin/rev-list.c
fetch-pack.c
list-objects-filter-options.c
list-objects-filter-options.h
t/t6112-rev-list-filters-objects.sh
transport-helper.c
upload-pack.c