http-walker: store url in a strbuf
authorJeff King <peff@peff.net>
Thu, 24 Sep 2015 21:07:31 +0000 (17:07 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 25 Sep 2015 17:18:18 +0000 (10:18 -0700)
commit54ba4c5fa2d7de216ca090ac2e657728462c81d5
treec76231dded57746aa6478fe63dd5d35b49707bd3
parent7d0581a9abe733d8880113370c4d956b50f5bd9f
http-walker: store url in a strbuf

We do an unchecked sprintf directly into our url buffer.
This doesn't overflow because we know that it was sized for
"$base/objects/info/http-alternates", and we are writing
"$base/objects/info/alternates", which must be smaller. But
that is not immediately obvious to a reader who is looking
for buffer overflows. Let's switch to a strbuf, so that we
do not have to think about this issue at all.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-walker.c