add_packed_git: convert strcpy into xsnprintf
authorJeff King <peff@peff.net>
Thu, 24 Sep 2015 21:06:55 +0000 (17:06 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 25 Sep 2015 17:18:18 +0000 (10:18 -0700)
commit48bcc1c3cc09db1a6da0ce47460fae6e5f7edd4b
tree67e3469fd97096b0f49c91600abbedea8208931a
parent330c8e26701c33f1d74dbe3c2692f29b5ed4ba5f
add_packed_git: convert strcpy into xsnprintf

We have the path "foo.idx", and we create a buffer big
enough to hold "foo.pack" and "foo.keep", and then strcpy
straight into it. This isn't a bug (we have enough space),
but it's very hard to tell from the strcpy that this is so.

Let's instead use strip_suffix to take off the ".idx",
record the size of our allocation, and use xsnprintf to make
sure we don't violate our assumptions.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
cache.h
sha1_file.c