index-pack: check .gitmodules files with --strict
[git/git.git] / fsck.c
CommitLineData
355885d5
MK
1#include "cache.h"
2#include "object.h"
3#include "blob.h"
4#include "tree.h"
5#include "tree-walk.h"
6#include "commit.h"
7#include "tag.h"
8#include "fsck.h"
cec097be 9#include "refs.h"
a18fcc9f 10#include "utf8.h"
cd94c6f9 11#include "sha1-array.h"
7b35efd7 12#include "decorate.h"
159e7b08 13#include "oidset.h"
27387444 14#include "packfile.h"
ed8b10f6
JK
15#include "submodule-config.h"
16#include "config.h"
159e7b08
JK
17
18static struct oidset gitmodules_found = OIDSET_INIT;
19static struct oidset gitmodules_done = OIDSET_INIT;
355885d5 20
f50c4407 21#define FSCK_FATAL -1
f27d05b1 22#define FSCK_INFO -2
f50c4407 23
c99ba492 24#define FOREACH_MSG_ID(FUNC) \
f50c4407
JS
25 /* fatal errors */ \
26 FUNC(NUL_IN_HEADER, FATAL) \
27 FUNC(UNTERMINATED_HEADER, FATAL) \
c99ba492
JS
28 /* errors */ \
29 FUNC(BAD_DATE, ERROR) \
30 FUNC(BAD_DATE_OVERFLOW, ERROR) \
31 FUNC(BAD_EMAIL, ERROR) \
32 FUNC(BAD_NAME, ERROR) \
33 FUNC(BAD_OBJECT_SHA1, ERROR) \
34 FUNC(BAD_PARENT_SHA1, ERROR) \
35 FUNC(BAD_TAG_OBJECT, ERROR) \
36 FUNC(BAD_TIMEZONE, ERROR) \
37 FUNC(BAD_TREE, ERROR) \
38 FUNC(BAD_TREE_SHA1, ERROR) \
39 FUNC(BAD_TYPE, ERROR) \
40 FUNC(DUPLICATE_ENTRIES, ERROR) \
41 FUNC(MISSING_AUTHOR, ERROR) \
42 FUNC(MISSING_COMMITTER, ERROR) \
43 FUNC(MISSING_EMAIL, ERROR) \
44 FUNC(MISSING_GRAFT, ERROR) \
45 FUNC(MISSING_NAME_BEFORE_EMAIL, ERROR) \
46 FUNC(MISSING_OBJECT, ERROR) \
47 FUNC(MISSING_PARENT, ERROR) \
48 FUNC(MISSING_SPACE_BEFORE_DATE, ERROR) \
49 FUNC(MISSING_SPACE_BEFORE_EMAIL, ERROR) \
50 FUNC(MISSING_TAG, ERROR) \
51 FUNC(MISSING_TAG_ENTRY, ERROR) \
52 FUNC(MISSING_TAG_OBJECT, ERROR) \
53 FUNC(MISSING_TREE, ERROR) \
159e7b08 54 FUNC(MISSING_TREE_OBJECT, ERROR) \
c99ba492
JS
55 FUNC(MISSING_TYPE, ERROR) \
56 FUNC(MISSING_TYPE_ENTRY, ERROR) \
c9ad147f 57 FUNC(MULTIPLE_AUTHORS, ERROR) \
c99ba492
JS
58 FUNC(TAG_OBJECT_NOT_TAG, ERROR) \
59 FUNC(TREE_NOT_SORTED, ERROR) \
60 FUNC(UNKNOWN_TYPE, ERROR) \
c99ba492 61 FUNC(ZERO_PADDED_DATE, ERROR) \
159e7b08
JK
62 FUNC(GITMODULES_MISSING, ERROR) \
63 FUNC(GITMODULES_BLOB, ERROR) \
ed8b10f6
JK
64 FUNC(GITMODULES_PARSE, ERROR) \
65 FUNC(GITMODULES_NAME, ERROR) \
c99ba492
JS
66 /* warnings */ \
67 FUNC(BAD_FILEMODE, WARN) \
c99ba492
JS
68 FUNC(EMPTY_NAME, WARN) \
69 FUNC(FULL_PATHNAME, WARN) \
70 FUNC(HAS_DOT, WARN) \
71 FUNC(HAS_DOTDOT, WARN) \
72 FUNC(HAS_DOTGIT, WARN) \
c99ba492 73 FUNC(NULL_SHA1, WARN) \
f27d05b1 74 FUNC(ZERO_PADDED_FILEMODE, WARN) \
6d2d780f 75 FUNC(NUL_IN_COMMIT, WARN) \
f27d05b1
JS
76 /* infos (reported as warnings, but ignored by default) */ \
77 FUNC(BAD_TAG_NAME, INFO) \
78 FUNC(MISSING_TAGGER_ENTRY, INFO)
c99ba492
JS
79
80#define MSG_ID(id, msg_type) FSCK_MSG_##id,
81enum fsck_msg_id {
82 FOREACH_MSG_ID(MSG_ID)
83 FSCK_MSG_MAX
84};
85#undef MSG_ID
86
f417eed8
JS
87#define STR(x) #x
88#define MSG_ID(id, msg_type) { STR(id), NULL, FSCK_##msg_type },
c99ba492 89static struct {
f417eed8
JS
90 const char *id_string;
91 const char *downcased;
c99ba492
JS
92 int msg_type;
93} msg_id_info[FSCK_MSG_MAX + 1] = {
94 FOREACH_MSG_ID(MSG_ID)
f417eed8 95 { NULL, NULL, -1 }
c99ba492
JS
96};
97#undef MSG_ID
98
f417eed8
JS
99static int parse_msg_id(const char *text)
100{
101 int i;
102
103 if (!msg_id_info[0].downcased) {
104 /* convert id_string to lower case, without underscores. */
105 for (i = 0; i < FSCK_MSG_MAX; i++) {
106 const char *p = msg_id_info[i].id_string;
107 int len = strlen(p);
108 char *q = xmalloc(len);
109
110 msg_id_info[i].downcased = q;
111 while (*p)
112 if (*p == '_')
113 p++;
114 else
115 *(q)++ = tolower(*(p)++);
116 *q = '\0';
117 }
118 }
119
120 for (i = 0; i < FSCK_MSG_MAX; i++)
121 if (!strcmp(text, msg_id_info[i].downcased))
122 return i;
123
124 return -1;
125}
126
c99ba492
JS
127static int fsck_msg_type(enum fsck_msg_id msg_id,
128 struct fsck_options *options)
129{
130 int msg_type;
131
0282f4dc
JS
132 assert(msg_id >= 0 && msg_id < FSCK_MSG_MAX);
133
134 if (options->msg_type)
135 msg_type = options->msg_type[msg_id];
136 else {
137 msg_type = msg_id_info[msg_id].msg_type;
138 if (options->strict && msg_type == FSCK_WARN)
139 msg_type = FSCK_ERROR;
140 }
c99ba492
JS
141
142 return msg_type;
143}
144
cd94c6f9
JS
145static void init_skiplist(struct fsck_options *options, const char *path)
146{
910650d2 147 static struct oid_array skiplist = OID_ARRAY_INIT;
cd94c6f9 148 int sorted, fd;
365c27fb 149 char buffer[GIT_MAX_HEXSZ + 1];
150 struct object_id oid;
cd94c6f9
JS
151
152 if (options->skiplist)
153 sorted = options->skiplist->sorted;
154 else {
155 sorted = 1;
156 options->skiplist = &skiplist;
157 }
158
159 fd = open(path, O_RDONLY);
160 if (fd < 0)
161 die("Could not open skip list: %s", path);
162 for (;;) {
365c27fb 163 const char *p;
cd94c6f9
JS
164 int result = read_in_full(fd, buffer, sizeof(buffer));
165 if (result < 0)
166 die_errno("Could not read '%s'", path);
167 if (!result)
168 break;
365c27fb 169 if (parse_oid_hex(buffer, &oid, &p) || *p != '\n')
cd94c6f9 170 die("Invalid SHA-1: %s", buffer);
910650d2 171 oid_array_append(&skiplist, &oid);
cd94c6f9 172 if (sorted && skiplist.nr > 1 &&
ee3051bd 173 oidcmp(&skiplist.oid[skiplist.nr - 2],
174 &oid) > 0)
cd94c6f9
JS
175 sorted = 0;
176 }
177 close(fd);
178
179 if (sorted)
180 skiplist.sorted = 1;
181}
182
0282f4dc
JS
183static int parse_msg_type(const char *str)
184{
185 if (!strcmp(str, "error"))
186 return FSCK_ERROR;
187 else if (!strcmp(str, "warn"))
188 return FSCK_WARN;
efaba7cc
JS
189 else if (!strcmp(str, "ignore"))
190 return FSCK_IGNORE;
0282f4dc
JS
191 else
192 die("Unknown fsck message type: '%s'", str);
193}
194
5d477a33
JS
195int is_valid_msg_type(const char *msg_id, const char *msg_type)
196{
197 if (parse_msg_id(msg_id) < 0)
198 return 0;
199 parse_msg_type(msg_type);
200 return 1;
201}
202
0282f4dc
JS
203void fsck_set_msg_type(struct fsck_options *options,
204 const char *msg_id, const char *msg_type)
205{
206 int id = parse_msg_id(msg_id), type;
207
208 if (id < 0)
209 die("Unhandled message id: %s", msg_id);
210 type = parse_msg_type(msg_type);
211
f50c4407
JS
212 if (type != FSCK_ERROR && msg_id_info[id].msg_type == FSCK_FATAL)
213 die("Cannot demote %s to %s", msg_id, msg_type);
214
0282f4dc
JS
215 if (!options->msg_type) {
216 int i;
b32fa95f
JK
217 int *msg_type;
218 ALLOC_ARRAY(msg_type, FSCK_MSG_MAX);
0282f4dc
JS
219 for (i = 0; i < FSCK_MSG_MAX; i++)
220 msg_type[i] = fsck_msg_type(i, options);
221 options->msg_type = msg_type;
222 }
223
224 options->msg_type[id] = type;
225}
226
227void fsck_set_msg_types(struct fsck_options *options, const char *values)
228{
229 char *buf = xstrdup(values), *to_free = buf;
230 int done = 0;
231
232 while (!done) {
233 int len = strcspn(buf, " ,|"), equal;
234
235 done = !buf[len];
236 if (!len) {
237 buf++;
238 continue;
239 }
240 buf[len] = '\0';
241
242 for (equal = 0;
243 equal < len && buf[equal] != '=' && buf[equal] != ':';
244 equal++)
245 buf[equal] = tolower(buf[equal]);
246 buf[equal] = '\0';
247
cd94c6f9
JS
248 if (!strcmp(buf, "skiplist")) {
249 if (equal == len)
250 die("skiplist requires a path");
251 init_skiplist(options, buf + equal + 1);
252 buf += len + 1;
253 continue;
254 }
255
0282f4dc
JS
256 if (equal == len)
257 die("Missing '=': '%s'", buf);
355885d5 258
0282f4dc
JS
259 fsck_set_msg_type(options, buf, buf + equal + 1);
260 buf += len + 1;
261 }
262 free(to_free);
263}
264
71ab8fa8
JS
265static void append_msg_id(struct strbuf *sb, const char *msg_id)
266{
267 for (;;) {
268 char c = *(msg_id)++;
269
270 if (!c)
271 break;
272 if (c != '_')
273 strbuf_addch(sb, tolower(c));
274 else {
275 assert(*msg_id);
276 strbuf_addch(sb, *(msg_id)++);
277 }
278 }
279
280 strbuf_addstr(sb, ": ");
281}
282
c99ba492
JS
283__attribute__((format (printf, 4, 5)))
284static int report(struct fsck_options *options, struct object *object,
285 enum fsck_msg_id id, const char *fmt, ...)
286{
287 va_list ap;
288 struct strbuf sb = STRBUF_INIT;
289 int msg_type = fsck_msg_type(id, options), result;
290
efaba7cc
JS
291 if (msg_type == FSCK_IGNORE)
292 return 0;
293
cd94c6f9 294 if (options->skiplist && object &&
910650d2 295 oid_array_lookup(options->skiplist, &object->oid) >= 0)
cd94c6f9
JS
296 return 0;
297
f50c4407
JS
298 if (msg_type == FSCK_FATAL)
299 msg_type = FSCK_ERROR;
f27d05b1
JS
300 else if (msg_type == FSCK_INFO)
301 msg_type = FSCK_WARN;
f50c4407 302
71ab8fa8
JS
303 append_msg_id(&sb, msg_id_info[id].id_string);
304
c99ba492
JS
305 va_start(ap, fmt);
306 strbuf_vaddf(&sb, fmt, ap);
1cd772cc 307 result = options->error_func(options, object, msg_type, sb.buf);
c99ba492
JS
308 strbuf_release(&sb);
309 va_end(ap);
310
311 return result;
312}
313
7b35efd7
JS
314static char *get_object_name(struct fsck_options *options, struct object *obj)
315{
316 if (!options->object_names)
317 return NULL;
318 return lookup_decoration(options->object_names, obj);
319}
320
321static void put_object_name(struct fsck_options *options, struct object *obj,
322 const char *fmt, ...)
323{
324 va_list ap;
325 struct strbuf buf = STRBUF_INIT;
326 char *existing;
327
328 if (!options->object_names)
329 return;
330 existing = lookup_decoration(options->object_names, obj);
331 if (existing)
332 return;
333 va_start(ap, fmt);
334 strbuf_vaddf(&buf, fmt, ap);
335 add_decoration(options->object_names, obj, strbuf_detach(&buf, NULL));
336 va_end(ap);
337}
338
90cf590f
JS
339static const char *describe_object(struct fsck_options *o, struct object *obj)
340{
341 static struct strbuf buf = STRBUF_INIT;
342 char *name;
343
344 strbuf_reset(&buf);
345 strbuf_addstr(&buf, oid_to_hex(&obj->oid));
346 if (o->object_names && (name = lookup_decoration(o->object_names, obj)))
347 strbuf_addf(&buf, " (%s)", name);
348
349 return buf.buf;
350}
351
22410549 352static int fsck_walk_tree(struct tree *tree, void *data, struct fsck_options *options)
355885d5
MK
353{
354 struct tree_desc desc;
355 struct name_entry entry;
356 int res = 0;
7b35efd7 357 const char *name;
355885d5
MK
358
359 if (parse_tree(tree))
360 return -1;
361
7b35efd7 362 name = get_object_name(options, &tree->object);
8354fa3d
DT
363 if (init_tree_desc_gently(&desc, tree->buffer, tree->size))
364 return -1;
365 while (tree_entry_gently(&desc, &entry)) {
7b35efd7 366 struct object *obj;
355885d5
MK
367 int result;
368
369 if (S_ISGITLINK(entry.mode))
370 continue;
7b35efd7
JS
371
372 if (S_ISDIR(entry.mode)) {
2720f6db
RS
373 obj = (struct object *)lookup_tree(entry.oid);
374 if (name && obj)
7b35efd7
JS
375 put_object_name(options, obj, "%s%s/", name,
376 entry.path);
377 result = options->walk(obj, OBJ_TREE, data, options);
378 }
379 else if (S_ISREG(entry.mode) || S_ISLNK(entry.mode)) {
2720f6db
RS
380 obj = (struct object *)lookup_blob(entry.oid);
381 if (name && obj)
7b35efd7
JS
382 put_object_name(options, obj, "%s%s", name,
383 entry.path);
384 result = options->walk(obj, OBJ_BLOB, data, options);
385 }
355885d5 386 else {
82247e9b 387 result = error("in tree %s: entry %s has bad mode %.6o",
90cf590f 388 describe_object(options, &tree->object), entry.path, entry.mode);
355885d5
MK
389 }
390 if (result < 0)
391 return result;
392 if (!res)
393 res = result;
394 }
395 return res;
396}
397
22410549 398static int fsck_walk_commit(struct commit *commit, void *data, struct fsck_options *options)
355885d5 399{
7b35efd7 400 int counter = 0, generation = 0, name_prefix_len = 0;
355885d5
MK
401 struct commit_list *parents;
402 int res;
403 int result;
7b35efd7 404 const char *name;
355885d5
MK
405
406 if (parse_commit(commit))
407 return -1;
408
7b35efd7
JS
409 name = get_object_name(options, &commit->object);
410 if (name)
411 put_object_name(options, &commit->tree->object, "%s:", name);
412
22410549 413 result = options->walk((struct object *)commit->tree, OBJ_TREE, data, options);
355885d5
MK
414 if (result < 0)
415 return result;
416 res = result;
417
418 parents = commit->parents;
7b35efd7
JS
419 if (name && parents) {
420 int len = strlen(name), power;
421
422 if (len && name[len - 1] == '^') {
423 generation = 1;
424 name_prefix_len = len - 1;
425 }
426 else { /* parse ~<generation> suffix */
427 for (generation = 0, power = 1;
428 len && isdigit(name[len - 1]);
429 power *= 10)
430 generation += power * (name[--len] - '0');
431 if (power > 1 && len && name[len - 1] == '~')
432 name_prefix_len = len - 1;
433 }
434 }
435
355885d5 436 while (parents) {
7b35efd7
JS
437 if (name) {
438 struct object *obj = &parents->item->object;
439
440 if (++counter > 1)
441 put_object_name(options, obj, "%s^%d",
442 name, counter);
443 else if (generation > 0)
444 put_object_name(options, obj, "%.*s~%d",
445 name_prefix_len, name, generation + 1);
446 else
447 put_object_name(options, obj, "%s^", name);
448 }
22410549 449 result = options->walk((struct object *)parents->item, OBJ_COMMIT, data, options);
355885d5
MK
450 if (result < 0)
451 return result;
452 if (!res)
453 res = result;
454 parents = parents->next;
455 }
456 return res;
457}
458
22410549 459static int fsck_walk_tag(struct tag *tag, void *data, struct fsck_options *options)
355885d5 460{
7b35efd7
JS
461 char *name = get_object_name(options, &tag->object);
462
355885d5
MK
463 if (parse_tag(tag))
464 return -1;
7b35efd7
JS
465 if (name)
466 put_object_name(options, tag->tagged, "%s", name);
22410549 467 return options->walk(tag->tagged, OBJ_ANY, data, options);
355885d5
MK
468}
469
22410549 470int fsck_walk(struct object *obj, void *data, struct fsck_options *options)
355885d5
MK
471{
472 if (!obj)
473 return -1;
a2b22854
JK
474
475 if (obj->type == OBJ_NONE)
c251c83d 476 parse_object(&obj->oid);
a2b22854 477
355885d5
MK
478 switch (obj->type) {
479 case OBJ_BLOB:
480 return 0;
481 case OBJ_TREE:
22410549 482 return fsck_walk_tree((struct tree *)obj, data, options);
355885d5 483 case OBJ_COMMIT:
22410549 484 return fsck_walk_commit((struct commit *)obj, data, options);
355885d5 485 case OBJ_TAG:
22410549 486 return fsck_walk_tag((struct tag *)obj, data, options);
355885d5 487 default:
90cf590f 488 error("Unknown object type for %s", describe_object(options, obj));
355885d5
MK
489 return -1;
490 }
491}
ba002f3b
MK
492
493/*
494 * The entries in a tree are ordered in the _path_ order,
495 * which means that a directory entry is ordered by adding
496 * a slash to the end of it.
497 *
498 * So a directory called "a" is ordered _after_ a file
499 * called "a.c", because "a/" sorts after "a.c".
500 */
501#define TREE_UNORDERED (-1)
502#define TREE_HAS_DUPS (-2)
503
504static int verify_ordered(unsigned mode1, const char *name1, unsigned mode2, const char *name2)
505{
506 int len1 = strlen(name1);
507 int len2 = strlen(name2);
508 int len = len1 < len2 ? len1 : len2;
509 unsigned char c1, c2;
510 int cmp;
511
512 cmp = memcmp(name1, name2, len);
513 if (cmp < 0)
514 return 0;
515 if (cmp > 0)
516 return TREE_UNORDERED;
517
518 /*
519 * Ok, the first <len> characters are the same.
520 * Now we need to order the next one, but turn
521 * a '\0' into a '/' for a directory entry.
522 */
523 c1 = name1[len];
524 c2 = name2[len];
525 if (!c1 && !c2)
526 /*
527 * git-write-tree used to write out a nonsense tree that has
528 * entries with the same name, one blob and one tree. Make
529 * sure we do not have duplicate entries.
530 */
531 return TREE_HAS_DUPS;
532 if (!c1 && S_ISDIR(mode1))
533 c1 = '/';
534 if (!c2 && S_ISDIR(mode2))
535 c2 = '/';
536 return c1 < c2 ? 0 : TREE_UNORDERED;
537}
538
22410549 539static int fsck_tree(struct tree *item, struct fsck_options *options)
ba002f3b 540{
8354fa3d 541 int retval = 0;
c479d14a 542 int has_null_sha1 = 0;
ba002f3b
MK
543 int has_full_path = 0;
544 int has_empty_name = 0;
5d34a435
JK
545 int has_dot = 0;
546 int has_dotdot = 0;
5c17f512 547 int has_dotgit = 0;
ba002f3b
MK
548 int has_zero_pad = 0;
549 int has_bad_modes = 0;
550 int has_dup_entries = 0;
551 int not_properly_sorted = 0;
552 struct tree_desc desc;
553 unsigned o_mode;
554 const char *o_name;
ba002f3b 555
8354fa3d
DT
556 if (init_tree_desc_gently(&desc, item->buffer, item->size)) {
557 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
558 return retval;
559 }
ba002f3b
MK
560
561 o_mode = 0;
562 o_name = NULL;
ba002f3b
MK
563
564 while (desc.size) {
565 unsigned mode;
566 const char *name;
ce6663a9 567 const struct object_id *oid;
ba002f3b 568
ce6663a9 569 oid = tree_entry_extract(&desc, &name, &mode);
ba002f3b 570
ce6663a9 571 has_null_sha1 |= is_null_oid(oid);
effd12ec
HS
572 has_full_path |= !!strchr(name, '/');
573 has_empty_name |= !*name;
574 has_dot |= !strcmp(name, ".");
575 has_dotdot |= !strcmp(name, "..");
ed9c3220 576 has_dotgit |= is_hfs_dotgit(name) || is_ntfs_dotgit(name);
ba002f3b 577 has_zero_pad |= *(char *)desc.buffer == '0';
159e7b08
JK
578
579 if (is_hfs_dotgitmodules(name) || is_ntfs_dotgitmodules(name))
580 oidset_insert(&gitmodules_found, oid);
581
8354fa3d
DT
582 if (update_tree_entry_gently(&desc)) {
583 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
584 break;
585 }
ba002f3b
MK
586
587 switch (mode) {
588 /*
589 * Standard modes..
590 */
591 case S_IFREG | 0755:
592 case S_IFREG | 0644:
593 case S_IFLNK:
594 case S_IFDIR:
595 case S_IFGITLINK:
596 break;
597 /*
598 * This is nonstandard, but we had a few of these
599 * early on when we honored the full set of mode
600 * bits..
601 */
602 case S_IFREG | 0664:
22410549 603 if (!options->strict)
ba002f3b 604 break;
1cf01a34 605 /* fallthrough */
ba002f3b
MK
606 default:
607 has_bad_modes = 1;
608 }
609
610 if (o_name) {
611 switch (verify_ordered(o_mode, o_name, mode, name)) {
612 case TREE_UNORDERED:
613 not_properly_sorted = 1;
614 break;
615 case TREE_HAS_DUPS:
616 has_dup_entries = 1;
617 break;
618 default:
619 break;
620 }
621 }
622
623 o_mode = mode;
624 o_name = name;
ba002f3b
MK
625 }
626
c479d14a 627 if (has_null_sha1)
c99ba492 628 retval += report(options, &item->object, FSCK_MSG_NULL_SHA1, "contains entries pointing to null sha1");
ba002f3b 629 if (has_full_path)
c99ba492 630 retval += report(options, &item->object, FSCK_MSG_FULL_PATHNAME, "contains full pathnames");
ba002f3b 631 if (has_empty_name)
c99ba492 632 retval += report(options, &item->object, FSCK_MSG_EMPTY_NAME, "contains empty pathname");
5d34a435 633 if (has_dot)
c99ba492 634 retval += report(options, &item->object, FSCK_MSG_HAS_DOT, "contains '.'");
5d34a435 635 if (has_dotdot)
c99ba492 636 retval += report(options, &item->object, FSCK_MSG_HAS_DOTDOT, "contains '..'");
5c17f512 637 if (has_dotgit)
c99ba492 638 retval += report(options, &item->object, FSCK_MSG_HAS_DOTGIT, "contains '.git'");
ba002f3b 639 if (has_zero_pad)
c99ba492 640 retval += report(options, &item->object, FSCK_MSG_ZERO_PADDED_FILEMODE, "contains zero-padded file modes");
ba002f3b 641 if (has_bad_modes)
c99ba492 642 retval += report(options, &item->object, FSCK_MSG_BAD_FILEMODE, "contains bad file modes");
ba002f3b 643 if (has_dup_entries)
c99ba492 644 retval += report(options, &item->object, FSCK_MSG_DUPLICATE_ENTRIES, "contains duplicate file entries");
ba002f3b 645 if (not_properly_sorted)
c99ba492 646 retval += report(options, &item->object, FSCK_MSG_TREE_NOT_SORTED, "not properly sorted");
ba002f3b
MK
647 return retval;
648}
649
84d18c0b 650static int verify_headers(const void *data, unsigned long size,
b2f44feb 651 struct object *obj, struct fsck_options *options)
4d0d8975
JS
652{
653 const char *buffer = (const char *)data;
654 unsigned long i;
655
656 for (i = 0; i < size; i++) {
657 switch (buffer[i]) {
658 case '\0':
c99ba492
JS
659 return report(options, obj,
660 FSCK_MSG_NUL_IN_HEADER,
661 "unterminated header: NUL at offset %ld", i);
4d0d8975
JS
662 case '\n':
663 if (i + 1 < size && buffer[i + 1] == '\n')
664 return 0;
665 }
666 }
667
84d18c0b
JH
668 /*
669 * We did not find double-LF that separates the header
670 * and the body. Not having a body is not a crime but
671 * we do want to see the terminating LF for the last header
672 * line.
673 */
674 if (size && buffer[size - 1] == '\n')
675 return 0;
676
c99ba492
JS
677 return report(options, obj,
678 FSCK_MSG_UNTERMINATED_HEADER, "unterminated header");
4d0d8975
JS
679}
680
22410549 681static int fsck_ident(const char **ident, struct object *obj, struct fsck_options *options)
daae1922 682{
e6826e33 683 const char *p = *ident;
d4b8de04
JK
684 char *end;
685
e6826e33
JS
686 *ident = strchrnul(*ident, '\n');
687 if (**ident == '\n')
688 (*ident)++;
689
690 if (*p == '<')
c99ba492 691 return report(options, obj, FSCK_MSG_MISSING_NAME_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
e6826e33
JS
692 p += strcspn(p, "<>\n");
693 if (*p == '>')
c99ba492 694 return report(options, obj, FSCK_MSG_BAD_NAME, "invalid author/committer line - bad name");
e6826e33 695 if (*p != '<')
c99ba492 696 return report(options, obj, FSCK_MSG_MISSING_EMAIL, "invalid author/committer line - missing email");
e6826e33 697 if (p[-1] != ' ')
c99ba492 698 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
e6826e33
JS
699 p++;
700 p += strcspn(p, "<>\n");
701 if (*p != '>')
c99ba492 702 return report(options, obj, FSCK_MSG_BAD_EMAIL, "invalid author/committer line - bad email");
e6826e33
JS
703 p++;
704 if (*p != ' ')
c99ba492 705 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_DATE, "invalid author/committer line - missing space before date");
e6826e33
JS
706 p++;
707 if (*p == '0' && p[1] != ' ')
c99ba492 708 return report(options, obj, FSCK_MSG_ZERO_PADDED_DATE, "invalid author/committer line - zero-padded date");
1aeb7e75 709 if (date_overflows(parse_timestamp(p, &end, 10)))
c99ba492 710 return report(options, obj, FSCK_MSG_BAD_DATE_OVERFLOW, "invalid author/committer line - date causes integer overflow");
e6826e33 711 if ((end == p || *end != ' '))
c99ba492 712 return report(options, obj, FSCK_MSG_BAD_DATE, "invalid author/committer line - bad date");
e6826e33
JS
713 p = end + 1;
714 if ((*p != '+' && *p != '-') ||
715 !isdigit(p[1]) ||
716 !isdigit(p[2]) ||
717 !isdigit(p[3]) ||
718 !isdigit(p[4]) ||
719 (p[5] != '\n'))
c99ba492 720 return report(options, obj, FSCK_MSG_BAD_TIMEZONE, "invalid author/committer line - bad time zone");
e6826e33 721 p += 6;
daae1922
JN
722 return 0;
723}
724
bc6b8fc1 725static int fsck_commit_buffer(struct commit *commit, const char *buffer,
22410549 726 unsigned long size, struct fsck_options *options)
ba002f3b 727{
ba002f3b
MK
728 unsigned char tree_sha1[20], sha1[20];
729 struct commit_graft *graft;
c9ad147f 730 unsigned parent_count, parent_line_count = 0, author_count;
daae1922 731 int err;
6d2d780f 732 const char *buffer_begin = buffer;
ba002f3b 733
b2f44feb 734 if (verify_headers(buffer, size, &commit->object, options))
4d0d8975
JS
735 return -1;
736
cf4fff57 737 if (!skip_prefix(buffer, "tree ", &buffer))
c99ba492 738 return report(options, &commit->object, FSCK_MSG_MISSING_TREE, "invalid format - expected 'tree' line");
b3584761
JS
739 if (get_sha1_hex(buffer, tree_sha1) || buffer[40] != '\n') {
740 err = report(options, &commit->object, FSCK_MSG_BAD_TREE_SHA1, "invalid 'tree' line format - bad sha1");
741 if (err)
742 return err;
743 }
2d820a61 744 buffer += 41;
cf4fff57 745 while (skip_prefix(buffer, "parent ", &buffer)) {
b3584761
JS
746 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
747 err = report(options, &commit->object, FSCK_MSG_BAD_PARENT_SHA1, "invalid 'parent' line format - bad sha1");
748 if (err)
749 return err;
750 }
2d820a61 751 buffer += 41;
9d02150c 752 parent_line_count++;
ba002f3b 753 }
8b65a34c 754 graft = lookup_commit_graft(&commit->object.oid);
9d02150c 755 parent_count = commit_list_count(commit->parents);
ba002f3b 756 if (graft) {
9d02150c 757 if (graft->nr_parent == -1 && !parent_count)
ba002f3b 758 ; /* shallow commit */
b3584761
JS
759 else if (graft->nr_parent != parent_count) {
760 err = report(options, &commit->object, FSCK_MSG_MISSING_GRAFT, "graft objects missing");
761 if (err)
762 return err;
763 }
ba002f3b 764 } else {
b3584761
JS
765 if (parent_count != parent_line_count) {
766 err = report(options, &commit->object, FSCK_MSG_MISSING_PARENT, "parent objects missing");
767 if (err)
768 return err;
769 }
ba002f3b 770 }
c9ad147f
JS
771 author_count = 0;
772 while (skip_prefix(buffer, "author ", &buffer)) {
773 author_count++;
774 err = fsck_ident(&buffer, &commit->object, options);
775 if (err)
776 return err;
ba002f3b 777 }
c9ad147f
JS
778 if (author_count < 1)
779 err = report(options, &commit->object, FSCK_MSG_MISSING_AUTHOR, "invalid format - expected 'author' line");
780 else if (author_count > 1)
781 err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
daae1922
JN
782 if (err)
783 return err;
cf4fff57 784 if (!skip_prefix(buffer, "committer ", &buffer))
c99ba492 785 return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
22410549 786 err = fsck_ident(&buffer, &commit->object, options);
daae1922
JN
787 if (err)
788 return err;
5af29718
JH
789 if (!commit->tree) {
790 err = report(options, &commit->object, FSCK_MSG_BAD_TREE, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
791 if (err)
792 return err;
793 }
6d2d780f
JH
794 if (memchr(buffer_begin, '\0', size)) {
795 err = report(options, &commit->object, FSCK_MSG_NUL_IN_COMMIT,
796 "NUL byte in the commit object body");
797 if (err)
798 return err;
799 }
ba002f3b
MK
800 return 0;
801}
802
90a398bb 803static int fsck_commit(struct commit *commit, const char *data,
22410549 804 unsigned long size, struct fsck_options *options)
bc6b8fc1 805{
90a398bb 806 const char *buffer = data ? data : get_commit_buffer(commit, &size);
22410549 807 int ret = fsck_commit_buffer(commit, buffer, size, options);
90a398bb
JS
808 if (!data)
809 unuse_commit_buffer(commit, buffer);
bc6b8fc1
JK
810 return ret;
811}
812
cec097be 813static int fsck_tag_buffer(struct tag *tag, const char *data,
22410549 814 unsigned long size, struct fsck_options *options)
cec097be
JS
815{
816 unsigned char sha1[20];
817 int ret = 0;
818 const char *buffer;
819 char *to_free = NULL, *eol;
820 struct strbuf sb = STRBUF_INIT;
821
822 if (data)
823 buffer = data;
824 else {
825 enum object_type type;
826
827 buffer = to_free =
ed1c9977 828 read_sha1_file(tag->object.oid.hash, &type, &size);
cec097be 829 if (!buffer)
c99ba492
JS
830 return report(options, &tag->object,
831 FSCK_MSG_MISSING_TAG_OBJECT,
cec097be
JS
832 "cannot read tag object");
833
834 if (type != OBJ_TAG) {
c99ba492
JS
835 ret = report(options, &tag->object,
836 FSCK_MSG_TAG_OBJECT_NOT_TAG,
cec097be 837 "expected tag got %s",
debca9d2 838 type_name(type));
cec097be
JS
839 goto done;
840 }
841 }
842
8a272f29
RS
843 ret = verify_headers(buffer, size, &tag->object, options);
844 if (ret)
cec097be
JS
845 goto done;
846
847 if (!skip_prefix(buffer, "object ", &buffer)) {
c99ba492 848 ret = report(options, &tag->object, FSCK_MSG_MISSING_OBJECT, "invalid format - expected 'object' line");
cec097be
JS
849 goto done;
850 }
851 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
c99ba492 852 ret = report(options, &tag->object, FSCK_MSG_BAD_OBJECT_SHA1, "invalid 'object' line format - bad sha1");
7d7d5b05
JS
853 if (ret)
854 goto done;
cec097be
JS
855 }
856 buffer += 41;
857
858 if (!skip_prefix(buffer, "type ", &buffer)) {
c99ba492 859 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE_ENTRY, "invalid format - expected 'type' line");
cec097be
JS
860 goto done;
861 }
862 eol = strchr(buffer, '\n');
863 if (!eol) {
c99ba492 864 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE, "invalid format - unexpected end after 'type' line");
cec097be
JS
865 goto done;
866 }
867 if (type_from_string_gently(buffer, eol - buffer, 1) < 0)
c99ba492 868 ret = report(options, &tag->object, FSCK_MSG_BAD_TYPE, "invalid 'type' value");
cec097be
JS
869 if (ret)
870 goto done;
871 buffer = eol + 1;
872
873 if (!skip_prefix(buffer, "tag ", &buffer)) {
c99ba492 874 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG_ENTRY, "invalid format - expected 'tag' line");
cec097be
JS
875 goto done;
876 }
877 eol = strchr(buffer, '\n');
878 if (!eol) {
c99ba492 879 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG, "invalid format - unexpected end after 'type' line");
cec097be
JS
880 goto done;
881 }
882 strbuf_addf(&sb, "refs/tags/%.*s", (int)(eol - buffer), buffer);
f27d05b1
JS
883 if (check_refname_format(sb.buf, 0)) {
884 ret = report(options, &tag->object, FSCK_MSG_BAD_TAG_NAME,
c99ba492 885 "invalid 'tag' name: %.*s",
7add4419 886 (int)(eol - buffer), buffer);
f27d05b1
JS
887 if (ret)
888 goto done;
889 }
cec097be
JS
890 buffer = eol + 1;
891
f27d05b1 892 if (!skip_prefix(buffer, "tagger ", &buffer)) {
cec097be 893 /* early tags do not contain 'tagger' lines; warn only */
f27d05b1
JS
894 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAGGER_ENTRY, "invalid format - expected 'tagger' line");
895 if (ret)
896 goto done;
897 }
cec097be 898 else
22410549 899 ret = fsck_ident(&buffer, &tag->object, options);
cec097be
JS
900
901done:
902 strbuf_release(&sb);
903 free(to_free);
904 return ret;
905}
906
90a398bb 907static int fsck_tag(struct tag *tag, const char *data,
22410549 908 unsigned long size, struct fsck_options *options)
ba002f3b
MK
909{
910 struct object *tagged = tag->tagged;
911
912 if (!tagged)
c99ba492 913 return report(options, &tag->object, FSCK_MSG_BAD_TAG_OBJECT, "could not load tagged object");
cec097be 914
22410549 915 return fsck_tag_buffer(tag, data, size, options);
ba002f3b
MK
916}
917
ed8b10f6
JK
918struct fsck_gitmodules_data {
919 struct object *obj;
920 struct fsck_options *options;
921 int ret;
922};
923
924static int fsck_gitmodules_fn(const char *var, const char *value, void *vdata)
925{
926 struct fsck_gitmodules_data *data = vdata;
927 const char *subsection, *key;
928 int subsection_len;
929 char *name;
930
931 if (parse_config_key(var, "submodule", &subsection, &subsection_len, &key) < 0 ||
932 !subsection)
933 return 0;
934
935 name = xmemdupz(subsection, subsection_len);
936 if (check_submodule_name(name) < 0)
937 data->ret |= report(data->options, data->obj,
938 FSCK_MSG_GITMODULES_NAME,
939 "disallowed submodule name: %s",
940 name);
941 free(name);
942
943 return 0;
944}
945
7ac4f3a0
JK
946static int fsck_blob(struct blob *blob, const char *buf,
947 unsigned long size, struct fsck_options *options)
948{
ed8b10f6
JK
949 struct fsck_gitmodules_data data;
950
951 if (!oidset_contains(&gitmodules_found, &blob->object.oid))
952 return 0;
953 oidset_insert(&gitmodules_done, &blob->object.oid);
954
955 if (!buf) {
956 /*
957 * A missing buffer here is a sign that the caller found the
958 * blob too gigantic to load into memory. Let's just consider
959 * that an error.
960 */
961 return report(options, &blob->object,
962 FSCK_MSG_GITMODULES_PARSE,
963 ".gitmodules too large to parse");
964 }
965
966 data.obj = &blob->object;
967 data.options = options;
968 data.ret = 0;
969 if (git_config_from_mem(fsck_gitmodules_fn, CONFIG_ORIGIN_BLOB,
970 ".gitmodules", buf, size, &data))
971 data.ret |= report(options, &blob->object,
972 FSCK_MSG_GITMODULES_PARSE,
973 "could not parse gitmodules blob");
974
975 return data.ret;
7ac4f3a0
JK
976}
977
90a398bb 978int fsck_object(struct object *obj, void *data, unsigned long size,
22410549 979 struct fsck_options *options)
ba002f3b
MK
980{
981 if (!obj)
c99ba492 982 return report(options, obj, FSCK_MSG_BAD_OBJECT_SHA1, "no valid object to fsck");
ba002f3b
MK
983
984 if (obj->type == OBJ_BLOB)
7ac4f3a0 985 return fsck_blob((struct blob *)obj, data, size, options);
ba002f3b 986 if (obj->type == OBJ_TREE)
22410549 987 return fsck_tree((struct tree *) obj, options);
ba002f3b 988 if (obj->type == OBJ_COMMIT)
90a398bb 989 return fsck_commit((struct commit *) obj, (const char *) data,
22410549 990 size, options);
ba002f3b 991 if (obj->type == OBJ_TAG)
90a398bb 992 return fsck_tag((struct tag *) obj, (const char *) data,
22410549 993 size, options);
ba002f3b 994
c99ba492 995 return report(options, obj, FSCK_MSG_UNKNOWN_TYPE, "unknown type '%d' (internal fsck error)",
ba002f3b
MK
996 obj->type);
997}
d6ffc8d7 998
1cd772cc
JS
999int fsck_error_function(struct fsck_options *o,
1000 struct object *obj, int msg_type, const char *message)
d6ffc8d7 1001{
0282f4dc 1002 if (msg_type == FSCK_WARN) {
90cf590f 1003 warning("object %s: %s", describe_object(o, obj), message);
0282f4dc
JS
1004 return 0;
1005 }
90cf590f 1006 error("object %s: %s", describe_object(o, obj), message);
d6ffc8d7
MK
1007 return 1;
1008}
159e7b08
JK
1009
1010int fsck_finish(struct fsck_options *options)
1011{
1012 int ret = 0;
1013 struct oidset_iter iter;
1014 const struct object_id *oid;
1015
1016 oidset_iter_init(&gitmodules_found, &iter);
1017 while ((oid = oidset_iter_next(&iter))) {
1018 struct blob *blob;
1019 enum object_type type;
1020 unsigned long size;
1021 char *buf;
1022
1023 if (oidset_contains(&gitmodules_done, oid))
1024 continue;
1025
1026 blob = lookup_blob(oid);
1027 if (!blob) {
1028 ret |= report(options, &blob->object,
1029 FSCK_MSG_GITMODULES_BLOB,
1030 "non-blob found at .gitmodules");
1031 continue;
1032 }
1033
1034 buf = read_sha1_file(oid->hash, &type, &size);
1035 if (!buf) {
27387444
JK
1036 if (is_promisor_object(&blob->object.oid))
1037 continue;
159e7b08
JK
1038 ret |= report(options, &blob->object,
1039 FSCK_MSG_GITMODULES_MISSING,
1040 "unable to read .gitmodules blob");
1041 continue;
1042 }
1043
1044 if (type == OBJ_BLOB)
1045 ret |= fsck_blob(blob, buf, size, options);
1046 else
1047 ret |= report(options, &blob->object,
1048 FSCK_MSG_GITMODULES_BLOB,
1049 "non-blob found at .gitmodules");
1050 free(buf);
1051 }
1052
1053
1054 oidset_clear(&gitmodules_found);
1055 oidset_clear(&gitmodules_done);
1056 return ret;
1057}