Merge branch 'maint'
[git/git.git] / revision.c
CommitLineData
ae563542
LT
1#include "cache.h"
2#include "tag.h"
3#include "blob.h"
4#include "tree.h"
5#include "commit.h"
a4a88b2b 6#include "diff.h"
ae563542
LT
7#include "refs.h"
8#include "revision.h"
7fefda5c 9#include "graph.h"
8ecae9b0 10#include "grep.h"
8860fd42 11#include "reflog-walk.h"
d7a17cad 12#include "patch-ids.h"
f35f5603 13#include "decorate.h"
78892e32 14#include "log-tree.h"
ae563542 15
cdcefbc9
LT
16volatile show_early_output_fn_t show_early_output;
17
cf2ab916 18char *path_name(const struct name_path *path, const char *name)
ae563542 19{
cf2ab916 20 const struct name_path *p;
ae563542
LT
21 char *n, *m;
22 int nlen = strlen(name);
23 int len = nlen + 1;
24
25 for (p = path; p; p = p->up) {
26 if (p->elem_len)
27 len += p->elem_len + 1;
28 }
29 n = xmalloc(len);
30 m = n + len - (nlen + 1);
31 strcpy(m, name);
32 for (p = path; p; p = p->up) {
33 if (p->elem_len) {
34 m -= p->elem_len + 1;
35 memcpy(m, p->elem, p->elem_len);
36 m[p->elem_len] = '/';
37 }
38 }
39 return n;
40}
41
1f1e895f
LT
42void add_object(struct object *obj,
43 struct object_array *p,
44 struct name_path *path,
45 const char *name)
ae563542 46{
1f1e895f 47 add_object_array(obj, path_name(path, name), p);
ae563542
LT
48}
49
50static void mark_blob_uninteresting(struct blob *blob)
51{
c1ee9013
MK
52 if (!blob)
53 return;
ae563542
LT
54 if (blob->object.flags & UNINTERESTING)
55 return;
56 blob->object.flags |= UNINTERESTING;
57}
58
59void mark_tree_uninteresting(struct tree *tree)
60{
f75e53ed 61 struct tree_desc desc;
4c068a98 62 struct name_entry entry;
ae563542 63 struct object *obj = &tree->object;
ae563542 64
c1ee9013
MK
65 if (!tree)
66 return;
ae563542
LT
67 if (obj->flags & UNINTERESTING)
68 return;
69 obj->flags |= UNINTERESTING;
70 if (!has_sha1_file(obj->sha1))
71 return;
72 if (parse_tree(tree) < 0)
73 die("bad tree %s", sha1_to_hex(obj->sha1));
f75e53ed 74
6fda5e51 75 init_tree_desc(&desc, tree->buffer, tree->size);
4c068a98 76 while (tree_entry(&desc, &entry)) {
4d1012c3
LT
77 switch (object_type(entry.mode)) {
78 case OBJ_TREE:
4c068a98 79 mark_tree_uninteresting(lookup_tree(entry.sha1));
4d1012c3
LT
80 break;
81 case OBJ_BLOB:
4c068a98 82 mark_blob_uninteresting(lookup_blob(entry.sha1));
4d1012c3
LT
83 break;
84 default:
85 /* Subproject commit - not in this repository */
86 break;
87 }
ae563542 88 }
f75e53ed
LT
89
90 /*
91 * We don't care about the tree any more
92 * after it has been marked uninteresting.
93 */
94 free(tree->buffer);
95 tree->buffer = NULL;
ae563542
LT
96}
97
98void mark_parents_uninteresting(struct commit *commit)
99{
100 struct commit_list *parents = commit->parents;
101
102 while (parents) {
103 struct commit *commit = parents->item;
d2c4af73
MU
104 if (!(commit->object.flags & UNINTERESTING)) {
105 commit->object.flags |= UNINTERESTING;
ae563542 106
d2c4af73
MU
107 /*
108 * Normally we haven't parsed the parent
109 * yet, so we won't have a parent of a parent
110 * here. However, it may turn out that we've
111 * reached this commit some other way (where it
112 * wasn't uninteresting), in which case we need
113 * to mark its parents recursively too..
114 */
115 if (commit->parents)
116 mark_parents_uninteresting(commit);
117 }
ae563542
LT
118
119 /*
120 * A missing commit is ok iff its parent is marked
121 * uninteresting.
122 *
123 * We just mark such a thing parsed, so that when
124 * it is popped next time around, we won't be trying
125 * to parse it and get an error.
126 */
127 if (!has_sha1_file(commit->object.sha1))
128 commit->object.parsed = 1;
129 parents = parents->next;
130 }
131}
132
2d93b9fa 133static void add_pending_object_with_mode(struct rev_info *revs, struct object *obj, const char *name, unsigned mode)
ae563542 134{
aa27e461
LT
135 if (revs->no_walk && (obj->flags & UNINTERESTING))
136 die("object ranges do not make sense when not walking revisions");
7b69b873
JS
137 if (revs->reflog_info && obj->type == OBJ_COMMIT &&
138 add_reflog_for_walk(revs->reflog_info,
139 (struct commit *)obj, name))
140 return;
bb6c2fba 141 add_object_array_with_mode(obj, name, &revs->pending, mode);
ae563542
LT
142}
143
2d93b9fa
JH
144void add_pending_object(struct rev_info *revs, struct object *obj, const char *name)
145{
146 add_pending_object_with_mode(revs, obj, name, S_IFINVALID);
147}
148
3384a2df
JH
149void add_head_to_pending(struct rev_info *revs)
150{
151 unsigned char sha1[20];
152 struct object *obj;
153 if (get_sha1("HEAD", sha1))
154 return;
155 obj = parse_object(sha1);
156 if (!obj)
157 return;
158 add_pending_object(revs, obj, "HEAD");
159}
160
cd2bdc53 161static struct object *get_reference(struct rev_info *revs, const char *name, const unsigned char *sha1, unsigned int flags)
ae563542
LT
162{
163 struct object *object;
164
165 object = parse_object(sha1);
166 if (!object)
167 die("bad object %s", name);
cd2bdc53
LT
168 object->flags |= flags;
169 return object;
170}
171
172static struct commit *handle_commit(struct rev_info *revs, struct object *object, const char *name)
173{
174 unsigned long flags = object->flags;
ae563542
LT
175
176 /*
177 * Tag object? Look what it points to..
178 */
1974632c 179 while (object->type == OBJ_TAG) {
ae563542 180 struct tag *tag = (struct tag *) object;
cd2bdc53 181 if (revs->tag_objects && !(flags & UNINTERESTING))
ae563542 182 add_pending_object(revs, object, tag->tag);
9684afd9
MK
183 if (!tag->tagged)
184 die("bad tag");
ae563542 185 object = parse_object(tag->tagged->sha1);
aeeae1b7
JH
186 if (!object) {
187 if (flags & UNINTERESTING)
188 return NULL;
ae563542 189 die("bad object %s", sha1_to_hex(tag->tagged->sha1));
aeeae1b7 190 }
ae563542
LT
191 }
192
193 /*
194 * Commit object? Just return it, we'll do all the complex
195 * reachability crud.
196 */
1974632c 197 if (object->type == OBJ_COMMIT) {
ae563542 198 struct commit *commit = (struct commit *)object;
ae563542
LT
199 if (parse_commit(commit) < 0)
200 die("unable to parse commit %s", name);
d9a83684 201 if (flags & UNINTERESTING) {
4262c1b0 202 commit->object.flags |= UNINTERESTING;
ae563542 203 mark_parents_uninteresting(commit);
d9a83684
LT
204 revs->limited = 1;
205 }
0f3a290b
LT
206 if (revs->show_source && !commit->util)
207 commit->util = (void *) name;
ae563542
LT
208 return commit;
209 }
210
211 /*
3ea3c215 212 * Tree object? Either mark it uninteresting, or add it
ae563542
LT
213 * to the list of objects to look at later..
214 */
1974632c 215 if (object->type == OBJ_TREE) {
ae563542
LT
216 struct tree *tree = (struct tree *)object;
217 if (!revs->tree_objects)
218 return NULL;
219 if (flags & UNINTERESTING) {
220 mark_tree_uninteresting(tree);
221 return NULL;
222 }
223 add_pending_object(revs, object, "");
224 return NULL;
225 }
226
227 /*
228 * Blob object? You know the drill by now..
229 */
1974632c 230 if (object->type == OBJ_BLOB) {
ae563542
LT
231 struct blob *blob = (struct blob *)object;
232 if (!revs->blob_objects)
233 return NULL;
234 if (flags & UNINTERESTING) {
235 mark_blob_uninteresting(blob);
236 return NULL;
237 }
238 add_pending_object(revs, object, "");
239 return NULL;
240 }
241 die("%s is unknown object", name);
242}
243
a4a88b2b
LT
244static int everybody_uninteresting(struct commit_list *orig)
245{
246 struct commit_list *list = orig;
247 while (list) {
248 struct commit *commit = list->item;
249 list = list->next;
250 if (commit->object.flags & UNINTERESTING)
251 continue;
252 return 0;
253 }
254 return 1;
255}
256
0a4ba7f8
JH
257/*
258 * The goal is to get REV_TREE_NEW as the result only if the
259 * diff consists of all '+' (and no other changes), and
260 * REV_TREE_DIFFERENT otherwise (of course if the trees are
261 * the same we want REV_TREE_SAME). That means that once we
262 * get to REV_TREE_DIFFERENT, we do not have to look any further.
263 */
8efdc326 264static int tree_difference = REV_TREE_SAME;
a4a88b2b
LT
265
266static void file_add_remove(struct diff_options *options,
267 int addremove, unsigned mode,
268 const unsigned char *sha1,
fd55a19e 269 const char *fullpath)
a4a88b2b 270{
8efdc326 271 int diff = REV_TREE_DIFFERENT;
a4a88b2b
LT
272
273 /*
8efdc326
FK
274 * Is it an add of a new file? It means that the old tree
275 * didn't have it at all, so we will turn "REV_TREE_SAME" ->
276 * "REV_TREE_NEW", but leave any "REV_TREE_DIFFERENT" alone
277 * (and if it already was "REV_TREE_NEW", we'll keep it
278 * "REV_TREE_NEW" of course).
a4a88b2b
LT
279 */
280 if (addremove == '+') {
281 diff = tree_difference;
8efdc326 282 if (diff != REV_TREE_SAME)
a4a88b2b 283 return;
8efdc326 284 diff = REV_TREE_NEW;
a4a88b2b
LT
285 }
286 tree_difference = diff;
dd47aa31 287 if (tree_difference == REV_TREE_DIFFERENT)
8f67f8ae 288 DIFF_OPT_SET(options, HAS_CHANGES);
a4a88b2b
LT
289}
290
291static void file_change(struct diff_options *options,
292 unsigned old_mode, unsigned new_mode,
293 const unsigned char *old_sha1,
294 const unsigned char *new_sha1,
fd55a19e 295 const char *fullpath)
a4a88b2b 296{
8efdc326 297 tree_difference = REV_TREE_DIFFERENT;
8f67f8ae 298 DIFF_OPT_SET(options, HAS_CHANGES);
a4a88b2b
LT
299}
300
3a5e8608 301static int rev_compare_tree(struct rev_info *revs, struct commit *parent, struct commit *commit)
a4a88b2b 302{
3a5e8608
LT
303 struct tree *t1 = parent->tree;
304 struct tree *t2 = commit->tree;
305
a4a88b2b 306 if (!t1)
8efdc326 307 return REV_TREE_NEW;
78892e32
LT
308
309 if (revs->simplify_by_decoration) {
310 /*
311 * If we are simplifying by decoration, then the commit
312 * is worth showing if it has a tag pointing at it.
313 */
314 if (lookup_decoration(&name_decoration, &commit->object))
315 return REV_TREE_DIFFERENT;
316 /*
317 * A commit that is not pointed by a tag is uninteresting
318 * if we are not limited by path. This means that you will
319 * see the usual "commits that touch the paths" plus any
320 * tagged commit by specifying both --simplify-by-decoration
321 * and pathspec.
322 */
323 if (!revs->prune_data)
324 return REV_TREE_SAME;
325 }
a4a88b2b 326 if (!t2)
8efdc326
FK
327 return REV_TREE_DIFFERENT;
328 tree_difference = REV_TREE_SAME;
8f67f8ae 329 DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES);
c4e05b1a 330 if (diff_tree_sha1(t1->object.sha1, t2->object.sha1, "",
cd2bdc53 331 &revs->pruning) < 0)
8efdc326 332 return REV_TREE_DIFFERENT;
a4a88b2b
LT
333 return tree_difference;
334}
335
3a5e8608 336static int rev_same_tree_as_empty(struct rev_info *revs, struct commit *commit)
a4a88b2b
LT
337{
338 int retval;
339 void *tree;
6fda5e51 340 unsigned long size;
a4a88b2b 341 struct tree_desc empty, real;
3a5e8608 342 struct tree *t1 = commit->tree;
a4a88b2b
LT
343
344 if (!t1)
345 return 0;
346
6fda5e51 347 tree = read_object_with_reference(t1->object.sha1, tree_type, &size, NULL);
a4a88b2b
LT
348 if (!tree)
349 return 0;
6fda5e51
LT
350 init_tree_desc(&real, tree, size);
351 init_tree_desc(&empty, "", 0);
a4a88b2b 352
0a4ba7f8 353 tree_difference = REV_TREE_SAME;
8f67f8ae 354 DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES);
cd2bdc53 355 retval = diff_tree(&empty, &real, "", &revs->pruning);
a4a88b2b
LT
356 free(tree);
357
0a4ba7f8 358 return retval >= 0 && (tree_difference == REV_TREE_SAME);
a4a88b2b
LT
359}
360
361static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit)
362{
363 struct commit_list **pp, *parent;
6631c736 364 int tree_changed = 0, tree_same = 0;
a4a88b2b 365
53b2c823
LT
366 /*
367 * If we don't do pruning, everything is interesting
368 */
7dc0fe3b 369 if (!revs->prune)
53b2c823 370 return;
53b2c823 371
a4a88b2b
LT
372 if (!commit->tree)
373 return;
374
375 if (!commit->parents) {
3a5e8608 376 if (rev_same_tree_as_empty(revs, commit))
7dc0fe3b 377 commit->object.flags |= TREESAME;
a4a88b2b
LT
378 return;
379 }
380
53b2c823
LT
381 /*
382 * Normal non-merge commit? If we don't want to make the
383 * history dense, we consider it always to be a change..
384 */
7dc0fe3b 385 if (!revs->dense && !commit->parents->next)
53b2c823 386 return;
53b2c823 387
a4a88b2b
LT
388 pp = &commit->parents;
389 while ((parent = *pp) != NULL) {
390 struct commit *p = parent->item;
391
cc0e6c5a
AR
392 if (parse_commit(p) < 0)
393 die("cannot simplify commit %s (because of %s)",
394 sha1_to_hex(commit->object.sha1),
395 sha1_to_hex(p->object.sha1));
3a5e8608 396 switch (rev_compare_tree(revs, p, commit)) {
8efdc326 397 case REV_TREE_SAME:
6631c736 398 tree_same = 1;
9202434c 399 if (!revs->simplify_history || (p->object.flags & UNINTERESTING)) {
f3219fbb
JH
400 /* Even if a merge with an uninteresting
401 * side branch brought the entire change
402 * we are interested in, we do not want
403 * to lose the other branches of this
404 * merge, so we just keep going.
405 */
406 pp = &parent->next;
407 continue;
408 }
a4a88b2b
LT
409 parent->next = NULL;
410 commit->parents = parent;
7dc0fe3b 411 commit->object.flags |= TREESAME;
a4a88b2b
LT
412 return;
413
8efdc326
FK
414 case REV_TREE_NEW:
415 if (revs->remove_empty_trees &&
3a5e8608 416 rev_same_tree_as_empty(revs, p)) {
c348f31a
JH
417 /* We are adding all the specified
418 * paths from this parent, so the
419 * history beyond this parent is not
420 * interesting. Remove its parents
421 * (they are grandparents for us).
422 * IOW, we pretend this parent is a
423 * "root" commit.
a41e109c 424 */
cc0e6c5a
AR
425 if (parse_commit(p) < 0)
426 die("cannot simplify commit %s (invalid %s)",
427 sha1_to_hex(commit->object.sha1),
428 sha1_to_hex(p->object.sha1));
c348f31a 429 p->parents = NULL;
a4a88b2b
LT
430 }
431 /* fallthrough */
8efdc326 432 case REV_TREE_DIFFERENT:
f3219fbb 433 tree_changed = 1;
a4a88b2b
LT
434 pp = &parent->next;
435 continue;
436 }
437 die("bad tree compare for commit %s", sha1_to_hex(commit->object.sha1));
438 }
6631c736 439 if (tree_changed && !tree_same)
7dc0fe3b
LT
440 return;
441 commit->object.flags |= TREESAME;
a4a88b2b
LT
442}
443
fce87ae5
AG
444static void insert_by_date_cached(struct commit *p, struct commit_list **head,
445 struct commit_list *cached_base, struct commit_list **cache)
446{
447 struct commit_list *new_entry;
448
449 if (cached_base && p->date < cached_base->item->date)
450 new_entry = insert_by_date(p, &cached_base->next);
451 else
452 new_entry = insert_by_date(p, head);
453
454 if (cache && (!*cache || p->date < (*cache)->item->date))
455 *cache = new_entry;
456}
457
458static int add_parents_to_list(struct rev_info *revs, struct commit *commit,
459 struct commit_list **list, struct commit_list **cache_ptr)
a4a88b2b
LT
460{
461 struct commit_list *parent = commit->parents;
577ed5c2 462 unsigned left_flag;
fce87ae5 463 struct commit_list *cached_base = cache_ptr ? *cache_ptr : NULL;
a4a88b2b 464
3381c790 465 if (commit->object.flags & ADDED)
cc0e6c5a 466 return 0;
3381c790
LT
467 commit->object.flags |= ADDED;
468
a4a88b2b
LT
469 /*
470 * If the commit is uninteresting, don't try to
471 * prune parents - we want the maximal uninteresting
472 * set.
473 *
474 * Normally we haven't parsed the parent
475 * yet, so we won't have a parent of a parent
476 * here. However, it may turn out that we've
477 * reached this commit some other way (where it
478 * wasn't uninteresting), in which case we need
479 * to mark its parents recursively too..
480 */
481 if (commit->object.flags & UNINTERESTING) {
482 while (parent) {
483 struct commit *p = parent->item;
484 parent = parent->next;
aeeae1b7
JH
485 if (p)
486 p->object.flags |= UNINTERESTING;
cc0e6c5a 487 if (parse_commit(p) < 0)
aeeae1b7 488 continue;
a4a88b2b
LT
489 if (p->parents)
490 mark_parents_uninteresting(p);
491 if (p->object.flags & SEEN)
492 continue;
493 p->object.flags |= SEEN;
fce87ae5 494 insert_by_date_cached(p, list, cached_base, cache_ptr);
a4a88b2b 495 }
cc0e6c5a 496 return 0;
a4a88b2b
LT
497 }
498
499 /*
500 * Ok, the commit wasn't uninteresting. Try to
501 * simplify the commit history and find the parent
502 * that has no differences in the path set if one exists.
503 */
53b2c823 504 try_to_simplify_commit(revs, commit);
a4a88b2b 505
ba1d4505 506 if (revs->no_walk)
cc0e6c5a 507 return 0;
ba1d4505 508
577ed5c2 509 left_flag = (commit->object.flags & SYMMETRIC_LEFT);
0053e902 510
d9c292e8 511 for (parent = commit->parents; parent; parent = parent->next) {
a4a88b2b
LT
512 struct commit *p = parent->item;
513
cc0e6c5a
AR
514 if (parse_commit(p) < 0)
515 return -1;
0f3a290b
LT
516 if (revs->show_source && !p->util)
517 p->util = commit->util;
577ed5c2 518 p->object.flags |= left_flag;
ad1012eb
LH
519 if (!(p->object.flags & SEEN)) {
520 p->object.flags |= SEEN;
fce87ae5 521 insert_by_date_cached(p, list, cached_base, cache_ptr);
ad1012eb 522 }
60d30b02 523 if (revs->first_parent_only)
d9c292e8 524 break;
a4a88b2b 525 }
cc0e6c5a 526 return 0;
a4a88b2b
LT
527}
528
36d56de6 529static void cherry_pick_list(struct commit_list *list, struct rev_info *revs)
d7a17cad
JH
530{
531 struct commit_list *p;
532 int left_count = 0, right_count = 0;
533 int left_first;
534 struct patch_ids ids;
535
536 /* First count the commits on the left and on the right */
537 for (p = list; p; p = p->next) {
538 struct commit *commit = p->item;
539 unsigned flags = commit->object.flags;
540 if (flags & BOUNDARY)
541 ;
542 else if (flags & SYMMETRIC_LEFT)
543 left_count++;
544 else
545 right_count++;
546 }
547
548 left_first = left_count < right_count;
549 init_patch_ids(&ids);
36d56de6
JS
550 if (revs->diffopt.nr_paths) {
551 ids.diffopts.nr_paths = revs->diffopt.nr_paths;
552 ids.diffopts.paths = revs->diffopt.paths;
553 ids.diffopts.pathlens = revs->diffopt.pathlens;
554 }
d7a17cad
JH
555
556 /* Compute patch-ids for one side */
557 for (p = list; p; p = p->next) {
558 struct commit *commit = p->item;
559 unsigned flags = commit->object.flags;
560
561 if (flags & BOUNDARY)
562 continue;
563 /*
564 * If we have fewer left, left_first is set and we omit
565 * commits on the right branch in this loop. If we have
566 * fewer right, we skip the left ones.
567 */
568 if (left_first != !!(flags & SYMMETRIC_LEFT))
569 continue;
570 commit->util = add_commit_patch_id(commit, &ids);
571 }
572
573 /* Check the other side */
574 for (p = list; p; p = p->next) {
575 struct commit *commit = p->item;
576 struct patch_id *id;
577 unsigned flags = commit->object.flags;
578
579 if (flags & BOUNDARY)
580 continue;
581 /*
582 * If we have fewer left, left_first is set and we omit
583 * commits on the left branch in this loop.
584 */
585 if (left_first == !!(flags & SYMMETRIC_LEFT))
586 continue;
587
588 /*
589 * Have we seen the same patch id?
590 */
591 id = has_commit_patch_id(commit, &ids);
592 if (!id)
593 continue;
594 id->seen = 1;
595 commit->object.flags |= SHOWN;
596 }
597
598 /* Now check the original side for seen ones */
599 for (p = list; p; p = p->next) {
600 struct commit *commit = p->item;
601 struct patch_id *ent;
602
603 ent = commit->util;
604 if (!ent)
605 continue;
606 if (ent->seen)
607 commit->object.flags |= SHOWN;
608 commit->util = NULL;
609 }
610
611 free_patch_ids(&ids);
612}
613
7d004199
LT
614/* How many extra uninteresting commits we want to see.. */
615#define SLOP 5
616
617static int still_interesting(struct commit_list *src, unsigned long date, int slop)
3131b713 618{
7d004199
LT
619 /*
620 * No source list at all? We're definitely done..
621 */
622 if (!src)
623 return 0;
624
625 /*
626 * Does the destination list contain entries with a date
627 * before the source list? Definitely _not_ done.
628 */
629 if (date < src->item->date)
630 return SLOP;
631
632 /*
633 * Does the source list still have interesting commits in
634 * it? Definitely not done..
635 */
636 if (!everybody_uninteresting(src))
637 return SLOP;
638
639 /* Ok, we're closing in.. */
640 return slop-1;
3131b713
LT
641}
642
cc0e6c5a 643static int limit_list(struct rev_info *revs)
a4a88b2b 644{
7d004199
LT
645 int slop = SLOP;
646 unsigned long date = ~0ul;
a4a88b2b
LT
647 struct commit_list *list = revs->commits;
648 struct commit_list *newlist = NULL;
649 struct commit_list **p = &newlist;
650
651 while (list) {
652 struct commit_list *entry = list;
653 struct commit *commit = list->item;
654 struct object *obj = &commit->object;
cdcefbc9 655 show_early_output_fn_t show;
a4a88b2b
LT
656
657 list = list->next;
658 free(entry);
659
660 if (revs->max_age != -1 && (commit->date < revs->max_age))
661 obj->flags |= UNINTERESTING;
fce87ae5 662 if (add_parents_to_list(revs, commit, &list, NULL) < 0)
cc0e6c5a 663 return -1;
a4a88b2b
LT
664 if (obj->flags & UNINTERESTING) {
665 mark_parents_uninteresting(commit);
7d004199
LT
666 if (revs->show_all)
667 p = &commit_list_insert(commit, p)->next;
668 slop = still_interesting(list, date, slop);
669 if (slop)
3131b713 670 continue;
7d004199
LT
671 /* If showing all, add the whole pending list to the end */
672 if (revs->show_all)
673 *p = list;
674 break;
a4a88b2b
LT
675 }
676 if (revs->min_age != -1 && (commit->date > revs->min_age))
677 continue;
7d004199 678 date = commit->date;
a4a88b2b 679 p = &commit_list_insert(commit, p)->next;
cdcefbc9
LT
680
681 show = show_early_output;
682 if (!show)
683 continue;
684
685 show(revs, newlist);
686 show_early_output = NULL;
a4a88b2b 687 }
d7a17cad 688 if (revs->cherry_pick)
36d56de6 689 cherry_pick_list(newlist, revs);
d7a17cad 690
a4a88b2b 691 revs->commits = newlist;
cc0e6c5a 692 return 0;
a4a88b2b
LT
693}
694
63049292
JH
695struct all_refs_cb {
696 int all_flags;
71b03b42 697 int warned_bad_reflog;
63049292
JH
698 struct rev_info *all_revs;
699 const char *name_for_errormsg;
700};
ae563542 701
8da19775 702static int handle_one_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
ae563542 703{
63049292
JH
704 struct all_refs_cb *cb = cb_data;
705 struct object *object = get_reference(cb->all_revs, path, sha1,
706 cb->all_flags);
3d1efd8f 707 add_pending_object(cb->all_revs, object, path);
ae563542
LT
708 return 0;
709}
710
a5aa930d
UKK
711static void handle_refs(struct rev_info *revs, unsigned flags,
712 int (*for_each)(each_ref_fn, void *))
ae563542 713{
63049292
JH
714 struct all_refs_cb cb;
715 cb.all_revs = revs;
716 cb.all_flags = flags;
a5aa930d 717 for_each(handle_one_ref, &cb);
63049292
JH
718}
719
71b03b42 720static void handle_one_reflog_commit(unsigned char *sha1, void *cb_data)
63049292
JH
721{
722 struct all_refs_cb *cb = cb_data;
71b03b42
SP
723 if (!is_null_sha1(sha1)) {
724 struct object *o = parse_object(sha1);
725 if (o) {
726 o->flags |= cb->all_flags;
727 add_pending_object(cb->all_revs, o, "");
728 }
729 else if (!cb->warned_bad_reflog) {
46efd2d9 730 warning("reflog of '%s' references pruned commits",
71b03b42
SP
731 cb->name_for_errormsg);
732 cb->warned_bad_reflog = 1;
733 }
63049292 734 }
71b03b42
SP
735}
736
883d60fa
JS
737static int handle_one_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
738 const char *email, unsigned long timestamp, int tz,
739 const char *message, void *cb_data)
71b03b42
SP
740{
741 handle_one_reflog_commit(osha1, cb_data);
742 handle_one_reflog_commit(nsha1, cb_data);
63049292
JH
743 return 0;
744}
745
746static int handle_one_reflog(const char *path, const unsigned char *sha1, int flag, void *cb_data)
747{
748 struct all_refs_cb *cb = cb_data;
71b03b42 749 cb->warned_bad_reflog = 0;
63049292
JH
750 cb->name_for_errormsg = path;
751 for_each_reflog_ent(path, handle_one_reflog_ent, cb_data);
752 return 0;
753}
754
755static void handle_reflog(struct rev_info *revs, unsigned flags)
756{
757 struct all_refs_cb cb;
758 cb.all_revs = revs;
759 cb.all_flags = flags;
25b51e2c 760 for_each_reflog(handle_one_reflog, &cb);
ae563542
LT
761}
762
ea4a19e1
JH
763static int add_parents_only(struct rev_info *revs, const char *arg, int flags)
764{
765 unsigned char sha1[20];
766 struct object *it;
767 struct commit *commit;
768 struct commit_list *parents;
769
770 if (*arg == '^') {
771 flags ^= UNINTERESTING;
772 arg++;
773 }
774 if (get_sha1(arg, sha1))
775 return 0;
776 while (1) {
777 it = get_reference(revs, arg, sha1, 0);
1974632c 778 if (it->type != OBJ_TAG)
ea4a19e1 779 break;
9684afd9
MK
780 if (!((struct tag*)it)->tagged)
781 return 0;
e702496e 782 hashcpy(sha1, ((struct tag*)it)->tagged->sha1);
ea4a19e1 783 }
1974632c 784 if (it->type != OBJ_COMMIT)
ea4a19e1
JH
785 return 0;
786 commit = (struct commit *)it;
787 for (parents = commit->parents; parents; parents = parents->next) {
788 it = &parents->item->object;
789 it->flags |= flags;
790 add_pending_object(revs, it, arg);
791 }
792 return 1;
793}
794
db6296a5 795void init_revisions(struct rev_info *revs, const char *prefix)
8efdc326
FK
796{
797 memset(revs, 0, sizeof(*revs));
8e8f9987 798
6b9c58f4 799 revs->abbrev = DEFAULT_ABBREV;
8e8f9987 800 revs->ignore_merges = 1;
9202434c 801 revs->simplify_history = 1;
8f67f8ae
PH
802 DIFF_OPT_SET(&revs->pruning, RECURSIVE);
803 DIFF_OPT_SET(&revs->pruning, QUIET);
cd2bdc53
LT
804 revs->pruning.add_remove = file_add_remove;
805 revs->pruning.change = file_change;
8efdc326
FK
806 revs->lifo = 1;
807 revs->dense = 1;
db6296a5 808 revs->prefix = prefix;
8efdc326
FK
809 revs->max_age = -1;
810 revs->min_age = -1;
d5db6c9e 811 revs->skip_count = -1;
8efdc326
FK
812 revs->max_count = -1;
813
cd2bdc53
LT
814 revs->commit_format = CMIT_FMT_DEFAULT;
815
0843acfd
JK
816 revs->grep_filter.status_only = 1;
817 revs->grep_filter.pattern_tail = &(revs->grep_filter.pattern_list);
818 revs->grep_filter.regflags = REG_NEWLINE;
819
cd2bdc53 820 diff_setup(&revs->diffopt);
c0cb4a06 821 if (prefix && !revs->diffopt.prefix) {
cd676a51
JH
822 revs->diffopt.prefix = prefix;
823 revs->diffopt.prefix_length = strlen(prefix);
824 }
8efdc326
FK
825}
826
0d2c9d67
RS
827static void add_pending_commit_list(struct rev_info *revs,
828 struct commit_list *commit_list,
829 unsigned int flags)
830{
831 while (commit_list) {
832 struct object *object = &commit_list->item->object;
833 object->flags |= flags;
834 add_pending_object(revs, object, sha1_to_hex(object->sha1));
835 commit_list = commit_list->next;
836 }
837}
838
ae3e5e1e
JH
839static void prepare_show_merge(struct rev_info *revs)
840{
841 struct commit_list *bases;
842 struct commit *head, *other;
843 unsigned char sha1[20];
844 const char **prune = NULL;
845 int i, prune_num = 1; /* counting terminating NULL */
846
847 if (get_sha1("HEAD", sha1) || !(head = lookup_commit(sha1)))
848 die("--merge without HEAD?");
849 if (get_sha1("MERGE_HEAD", sha1) || !(other = lookup_commit(sha1)))
850 die("--merge without MERGE_HEAD?");
851 add_pending_object(revs, &head->object, "HEAD");
852 add_pending_object(revs, &other->object, "MERGE_HEAD");
853 bases = get_merge_bases(head, other, 1);
e82447b1
JH
854 add_pending_commit_list(revs, bases, UNINTERESTING);
855 free_commit_list(bases);
856 head->object.flags |= SYMMETRIC_LEFT;
ae3e5e1e
JH
857
858 if (!active_nr)
859 read_cache();
860 for (i = 0; i < active_nr; i++) {
861 struct cache_entry *ce = active_cache[i];
862 if (!ce_stage(ce))
863 continue;
864 if (ce_path_match(ce, revs->prune_data)) {
865 prune_num++;
866 prune = xrealloc(prune, sizeof(*prune) * prune_num);
867 prune[prune_num-2] = ce->name;
868 prune[prune_num-1] = NULL;
869 }
870 while ((i+1 < active_nr) &&
871 ce_same_name(ce, active_cache[i+1]))
872 i++;
873 }
874 revs->prune_data = prune;
e82447b1 875 revs->limited = 1;
ae3e5e1e
JH
876}
877
5d6f0935
JH
878int handle_revision_arg(const char *arg, struct rev_info *revs,
879 int flags,
880 int cant_be_filename)
881{
bb6c2fba 882 unsigned mode;
5d6f0935
JH
883 char *dotdot;
884 struct object *object;
885 unsigned char sha1[20];
886 int local_flags;
887
888 dotdot = strstr(arg, "..");
889 if (dotdot) {
890 unsigned char from_sha1[20];
891 const char *next = dotdot + 2;
892 const char *this = arg;
893 int symmetric = *next == '.';
894 unsigned int flags_exclude = flags ^ UNINTERESTING;
895
896 *dotdot = 0;
897 next += symmetric;
898
899 if (!*next)
900 next = "HEAD";
901 if (dotdot == arg)
902 this = "HEAD";
903 if (!get_sha1(this, from_sha1) &&
904 !get_sha1(next, sha1)) {
905 struct commit *a, *b;
906 struct commit_list *exclude;
907
908 a = lookup_commit_reference(from_sha1);
909 b = lookup_commit_reference(sha1);
910 if (!a || !b) {
911 die(symmetric ?
912 "Invalid symmetric difference expression %s...%s" :
913 "Invalid revision range %s..%s",
914 arg, next);
915 }
916
917 if (!cant_be_filename) {
918 *dotdot = '.';
919 verify_non_filename(revs->prefix, arg);
920 }
921
922 if (symmetric) {
923 exclude = get_merge_bases(a, b, 1);
924 add_pending_commit_list(revs, exclude,
925 flags_exclude);
926 free_commit_list(exclude);
577ed5c2 927 a->object.flags |= flags | SYMMETRIC_LEFT;
5d6f0935
JH
928 } else
929 a->object.flags |= flags_exclude;
930 b->object.flags |= flags;
931 add_pending_object(revs, &a->object, this);
932 add_pending_object(revs, &b->object, next);
933 return 0;
934 }
935 *dotdot = '.';
936 }
937 dotdot = strstr(arg, "^@");
938 if (dotdot && !dotdot[2]) {
939 *dotdot = 0;
940 if (add_parents_only(revs, arg, flags))
941 return 0;
942 *dotdot = '^';
943 }
62476c8e
JH
944 dotdot = strstr(arg, "^!");
945 if (dotdot && !dotdot[2]) {
946 *dotdot = 0;
947 if (!add_parents_only(revs, arg, flags ^ UNINTERESTING))
948 *dotdot = '^';
949 }
950
5d6f0935
JH
951 local_flags = 0;
952 if (*arg == '^') {
953 local_flags = UNINTERESTING;
954 arg++;
955 }
bb6c2fba 956 if (get_sha1_with_mode(arg, sha1, &mode))
5d6f0935
JH
957 return -1;
958 if (!cant_be_filename)
959 verify_non_filename(revs->prefix, arg);
960 object = get_reference(revs, arg, sha1, flags ^ local_flags);
bb6c2fba 961 add_pending_object_with_mode(revs, object, arg, mode);
5d6f0935
JH
962 return 0;
963}
964
1fc561d1
AB
965void read_revisions_from_stdin(struct rev_info *revs)
966{
967 char line[1000];
968
969 while (fgets(line, sizeof(line), stdin) != NULL) {
970 int len = strlen(line);
971 if (len && line[len - 1] == '\n')
972 line[--len] = '\0';
973 if (!len)
974 break;
975 if (line[0] == '-')
976 die("options not supported in --stdin mode");
977 if (handle_revision_arg(line, revs, 0, 1))
978 die("bad revision '%s'", line);
979 }
980}
981
2d10c555 982static void add_grep(struct rev_info *revs, const char *ptn, enum grep_pat_token what)
bd95fcd3 983{
0843acfd 984 append_grep_pattern(&revs->grep_filter, ptn, "command line", 0, what);
2d10c555
JH
985}
986
a4d7d2c6 987static void add_header_grep(struct rev_info *revs, enum grep_header_field field, const char *pattern)
2d10c555 988{
a4d7d2c6 989 append_header_grep_pattern(&revs->grep_filter, field, pattern);
bd95fcd3
JH
990}
991
992static void add_message_grep(struct rev_info *revs, const char *pattern)
993{
2d10c555 994 add_grep(revs, pattern, GREP_PATTERN_BODY);
bd95fcd3
JH
995}
996
6b61ec05
PH
997static int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
998 int *unkc, const char **unkv)
02e54220
PH
999{
1000 const char *arg = argv[0];
1001
1002 /* pseudo revision arguments */
1003 if (!strcmp(arg, "--all") || !strcmp(arg, "--branches") ||
1004 !strcmp(arg, "--tags") || !strcmp(arg, "--remotes") ||
1005 !strcmp(arg, "--reflog") || !strcmp(arg, "--not") ||
1006 !strcmp(arg, "--no-walk") || !strcmp(arg, "--do-walk"))
1007 {
1008 unkv[(*unkc)++] = arg;
0fe8c138 1009 return 1;
02e54220
PH
1010 }
1011
1012 if (!prefixcmp(arg, "--max-count=")) {
1013 revs->max_count = atoi(arg + 12);
1014 } else if (!prefixcmp(arg, "--skip=")) {
1015 revs->skip_count = atoi(arg + 7);
1016 } else if ((*arg == '-') && isdigit(arg[1])) {
1017 /* accept -<digit>, like traditional "head" */
1018 revs->max_count = atoi(arg + 1);
1019 } else if (!strcmp(arg, "-n")) {
1020 if (argc <= 1)
1021 return error("-n requires an argument");
1022 revs->max_count = atoi(argv[1]);
1023 return 2;
1024 } else if (!prefixcmp(arg, "-n")) {
1025 revs->max_count = atoi(arg + 2);
1026 } else if (!prefixcmp(arg, "--max-age=")) {
1027 revs->max_age = atoi(arg + 10);
1028 } else if (!prefixcmp(arg, "--since=")) {
1029 revs->max_age = approxidate(arg + 8);
1030 } else if (!prefixcmp(arg, "--after=")) {
1031 revs->max_age = approxidate(arg + 8);
1032 } else if (!prefixcmp(arg, "--min-age=")) {
1033 revs->min_age = atoi(arg + 10);
1034 } else if (!prefixcmp(arg, "--before=")) {
1035 revs->min_age = approxidate(arg + 9);
1036 } else if (!prefixcmp(arg, "--until=")) {
1037 revs->min_age = approxidate(arg + 8);
1038 } else if (!strcmp(arg, "--first-parent")) {
1039 revs->first_parent_only = 1;
1040 } else if (!strcmp(arg, "-g") || !strcmp(arg, "--walk-reflogs")) {
1041 init_reflog_walk(&revs->reflog_info);
1042 } else if (!strcmp(arg, "--default")) {
1043 if (argc <= 1)
1044 return error("bad --default argument");
1045 revs->def = argv[1];
1046 return 2;
1047 } else if (!strcmp(arg, "--merge")) {
1048 revs->show_merge = 1;
1049 } else if (!strcmp(arg, "--topo-order")) {
1050 revs->lifo = 1;
1051 revs->topo_order = 1;
6546b593
JH
1052 } else if (!strcmp(arg, "--simplify-merges")) {
1053 revs->simplify_merges = 1;
1054 revs->rewrite_parents = 1;
1055 revs->simplify_history = 0;
1056 revs->limited = 1;
78892e32
LT
1057 } else if (!strcmp(arg, "--simplify-by-decoration")) {
1058 revs->simplify_merges = 1;
1059 revs->rewrite_parents = 1;
1060 revs->simplify_history = 0;
1061 revs->simplify_by_decoration = 1;
1062 revs->limited = 1;
1063 revs->prune = 1;
1064 load_ref_decorations();
02e54220
PH
1065 } else if (!strcmp(arg, "--date-order")) {
1066 revs->lifo = 0;
1067 revs->topo_order = 1;
1068 } else if (!prefixcmp(arg, "--early-output")) {
1069 int count = 100;
1070 switch (arg[14]) {
1071 case '=':
1072 count = atoi(arg+15);
1073 /* Fallthrough */
1074 case 0:
1075 revs->topo_order = 1;
1076 revs->early_output = count;
1077 }
1078 } else if (!strcmp(arg, "--parents")) {
1079 revs->rewrite_parents = 1;
1080 revs->print_parents = 1;
1081 } else if (!strcmp(arg, "--dense")) {
1082 revs->dense = 1;
1083 } else if (!strcmp(arg, "--sparse")) {
1084 revs->dense = 0;
1085 } else if (!strcmp(arg, "--show-all")) {
1086 revs->show_all = 1;
1087 } else if (!strcmp(arg, "--remove-empty")) {
1088 revs->remove_empty_trees = 1;
1089 } else if (!strcmp(arg, "--no-merges")) {
1090 revs->no_merges = 1;
1091 } else if (!strcmp(arg, "--boundary")) {
1092 revs->boundary = 1;
1093 } else if (!strcmp(arg, "--left-right")) {
1094 revs->left_right = 1;
1095 } else if (!strcmp(arg, "--cherry-pick")) {
1096 revs->cherry_pick = 1;
1097 revs->limited = 1;
1098 } else if (!strcmp(arg, "--objects")) {
1099 revs->tag_objects = 1;
1100 revs->tree_objects = 1;
1101 revs->blob_objects = 1;
1102 } else if (!strcmp(arg, "--objects-edge")) {
1103 revs->tag_objects = 1;
1104 revs->tree_objects = 1;
1105 revs->blob_objects = 1;
1106 revs->edge_hint = 1;
1107 } else if (!strcmp(arg, "--unpacked")) {
1108 revs->unpacked = 1;
03a9683d
JH
1109 } else if (!prefixcmp(arg, "--unpacked=")) {
1110 die("--unpacked=<packfile> no longer supported.");
02e54220
PH
1111 } else if (!strcmp(arg, "-r")) {
1112 revs->diff = 1;
1113 DIFF_OPT_SET(&revs->diffopt, RECURSIVE);
1114 } else if (!strcmp(arg, "-t")) {
1115 revs->diff = 1;
1116 DIFF_OPT_SET(&revs->diffopt, RECURSIVE);
1117 DIFF_OPT_SET(&revs->diffopt, TREE_IN_RECURSIVE);
1118 } else if (!strcmp(arg, "-m")) {
1119 revs->ignore_merges = 0;
1120 } else if (!strcmp(arg, "-c")) {
1121 revs->diff = 1;
1122 revs->dense_combined_merges = 0;
1123 revs->combine_merges = 1;
1124 } else if (!strcmp(arg, "--cc")) {
1125 revs->diff = 1;
1126 revs->dense_combined_merges = 1;
1127 revs->combine_merges = 1;
1128 } else if (!strcmp(arg, "-v")) {
1129 revs->verbose_header = 1;
1130 } else if (!strcmp(arg, "--pretty")) {
1131 revs->verbose_header = 1;
1132 get_commit_format(arg+8, revs);
3a4c1a5e 1133 } else if (!prefixcmp(arg, "--pretty=") || !prefixcmp(arg, "--format=")) {
02e54220
PH
1134 revs->verbose_header = 1;
1135 get_commit_format(arg+9, revs);
de84accc
NS
1136 } else if (!strcmp(arg, "--oneline")) {
1137 revs->verbose_header = 1;
1138 get_commit_format("oneline", revs);
1139 revs->abbrev_commit = 1;
02e54220
PH
1140 } else if (!strcmp(arg, "--graph")) {
1141 revs->topo_order = 1;
1142 revs->rewrite_parents = 1;
1143 revs->graph = graph_init(revs);
1144 } else if (!strcmp(arg, "--root")) {
1145 revs->show_root_diff = 1;
1146 } else if (!strcmp(arg, "--no-commit-id")) {
1147 revs->no_commit_id = 1;
1148 } else if (!strcmp(arg, "--always")) {
1149 revs->always_show_header = 1;
1150 } else if (!strcmp(arg, "--no-abbrev")) {
1151 revs->abbrev = 0;
1152 } else if (!strcmp(arg, "--abbrev")) {
1153 revs->abbrev = DEFAULT_ABBREV;
1154 } else if (!prefixcmp(arg, "--abbrev=")) {
1155 revs->abbrev = strtoul(arg + 9, NULL, 10);
1156 if (revs->abbrev < MINIMUM_ABBREV)
1157 revs->abbrev = MINIMUM_ABBREV;
1158 else if (revs->abbrev > 40)
1159 revs->abbrev = 40;
1160 } else if (!strcmp(arg, "--abbrev-commit")) {
1161 revs->abbrev_commit = 1;
1162 } else if (!strcmp(arg, "--full-diff")) {
1163 revs->diff = 1;
1164 revs->full_diff = 1;
1165 } else if (!strcmp(arg, "--full-history")) {
1166 revs->simplify_history = 0;
1167 } else if (!strcmp(arg, "--relative-date")) {
1168 revs->date_mode = DATE_RELATIVE;
1169 } else if (!strncmp(arg, "--date=", 7)) {
1170 revs->date_mode = parse_date_format(arg + 7);
1171 } else if (!strcmp(arg, "--log-size")) {
1172 revs->show_log_size = 1;
1173 }
1174 /*
1175 * Grepping the commit log
1176 */
1177 else if (!prefixcmp(arg, "--author=")) {
a4d7d2c6 1178 add_header_grep(revs, GREP_HEADER_AUTHOR, arg+9);
02e54220 1179 } else if (!prefixcmp(arg, "--committer=")) {
a4d7d2c6 1180 add_header_grep(revs, GREP_HEADER_COMMITTER, arg+12);
02e54220
PH
1181 } else if (!prefixcmp(arg, "--grep=")) {
1182 add_message_grep(revs, arg+7);
1183 } else if (!strcmp(arg, "--extended-regexp") || !strcmp(arg, "-E")) {
0843acfd 1184 revs->grep_filter.regflags |= REG_EXTENDED;
02e54220 1185 } else if (!strcmp(arg, "--regexp-ignore-case") || !strcmp(arg, "-i")) {
0843acfd 1186 revs->grep_filter.regflags |= REG_ICASE;
02e54220 1187 } else if (!strcmp(arg, "--fixed-strings") || !strcmp(arg, "-F")) {
0843acfd 1188 revs->grep_filter.fixed = 1;
02e54220 1189 } else if (!strcmp(arg, "--all-match")) {
0843acfd 1190 revs->grep_filter.all_match = 1;
02e54220
PH
1191 } else if (!prefixcmp(arg, "--encoding=")) {
1192 arg += 11;
1193 if (strcmp(arg, "none"))
1194 git_log_output_encoding = xstrdup(arg);
1195 else
1196 git_log_output_encoding = "";
1197 } else if (!strcmp(arg, "--reverse")) {
1198 revs->reverse ^= 1;
1199 } else if (!strcmp(arg, "--children")) {
1200 revs->children.name = "children";
1201 revs->limited = 1;
1202 } else {
1203 int opts = diff_opt_parse(&revs->diffopt, argv, argc);
1204 if (!opts)
1205 unkv[(*unkc)++] = arg;
1206 return opts;
1207 }
1208
1209 return 1;
1210}
1211
6b61ec05
PH
1212void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
1213 const struct option *options,
1214 const char * const usagestr[])
1215{
1216 int n = handle_revision_opt(revs, ctx->argc, ctx->argv,
1217 &ctx->cpidx, ctx->out);
1218 if (n <= 0) {
1219 error("unknown option `%s'", ctx->argv[0]);
1220 usage_with_options(usagestr, options);
1221 }
1222 ctx->argv += n;
1223 ctx->argc -= n;
1224}
1225
ae563542
LT
1226/*
1227 * Parse revision information, filling in the "rev_info" structure,
1228 * and removing the used arguments from the argument list.
1229 *
765ac8ec
LT
1230 * Returns the number of arguments left that weren't recognized
1231 * (which are also moved to the head of the argument list)
ae563542 1232 */
a4a88b2b 1233int setup_revisions(int argc, const char **argv, struct rev_info *revs, const char *def)
ae563542 1234{
02e54220 1235 int i, flags, left, seen_dashdash;
ae563542 1236
ae563542
LT
1237 /* First, search for "--" */
1238 seen_dashdash = 0;
1239 for (i = 1; i < argc; i++) {
1240 const char *arg = argv[i];
1241 if (strcmp(arg, "--"))
1242 continue;
1243 argv[i] = NULL;
1244 argc = i;
a65f2005
JH
1245 if (argv[i + 1])
1246 revs->prune_data = get_pathspec(revs->prefix, argv + i + 1);
ae563542
LT
1247 seen_dashdash = 1;
1248 break;
1249 }
1250
02e54220
PH
1251 /* Second, deal with arguments and options */
1252 flags = 0;
1253 for (left = i = 1; i < argc; i++) {
ae563542 1254 const char *arg = argv[i];
ae563542 1255 if (*arg == '-') {
cd2bdc53 1256 int opts;
02e54220 1257
ae563542 1258 if (!strcmp(arg, "--all")) {
a5aa930d 1259 handle_refs(revs, flags, for_each_ref);
f0298cf1 1260 handle_refs(revs, flags, head_ref);
a5aa930d
UKK
1261 continue;
1262 }
1263 if (!strcmp(arg, "--branches")) {
1264 handle_refs(revs, flags, for_each_branch_ref);
1265 continue;
1266 }
1267 if (!strcmp(arg, "--tags")) {
1268 handle_refs(revs, flags, for_each_tag_ref);
1269 continue;
1270 }
1271 if (!strcmp(arg, "--remotes")) {
1272 handle_refs(revs, flags, for_each_remote_ref);
ae563542
LT
1273 continue;
1274 }
63049292
JH
1275 if (!strcmp(arg, "--reflog")) {
1276 handle_reflog(revs, flags);
1277 continue;
1278 }
ae563542
LT
1279 if (!strcmp(arg, "--not")) {
1280 flags ^= UNINTERESTING;
1281 continue;
1282 }
8e64006e
JS
1283 if (!strcmp(arg, "--no-walk")) {
1284 revs->no_walk = 1;
1285 continue;
1286 }
1287 if (!strcmp(arg, "--do-walk")) {
1288 revs->no_walk = 0;
1289 continue;
1290 }
2d10c555 1291
02e54220 1292 opts = handle_revision_opt(revs, argc - i, argv + i, &left, argv);
cd2bdc53 1293 if (opts > 0) {
cd2bdc53
LT
1294 i += opts - 1;
1295 continue;
1296 }
02e54220
PH
1297 if (opts < 0)
1298 exit(128);
ae563542
LT
1299 continue;
1300 }
ae563542 1301
5d6f0935
JH
1302 if (handle_revision_arg(arg, revs, flags, seen_dashdash)) {
1303 int j;
1304 if (seen_dashdash || *arg == '^')
ae563542
LT
1305 die("bad revision '%s'", arg);
1306
ea92f41f
JH
1307 /* If we didn't have a "--":
1308 * (1) all filenames must exist;
1309 * (2) all rev-args must not be interpretable
1310 * as a valid filename.
1311 * but the latter we have checked in the main loop.
1312 */
e23d0b4a
LT
1313 for (j = i; j < argc; j++)
1314 verify_filename(revs->prefix, argv[j]);
1315
5d6f0935
JH
1316 revs->prune_data = get_pathspec(revs->prefix,
1317 argv + i);
ae563542
LT
1318 break;
1319 }
ae563542 1320 }
5d6f0935 1321
02e54220
PH
1322 if (revs->def == NULL)
1323 revs->def = def;
1324 if (revs->show_merge)
ae3e5e1e 1325 prepare_show_merge(revs);
02e54220 1326 if (revs->def && !revs->pending.nr) {
ae563542 1327 unsigned char sha1[20];
cd2bdc53 1328 struct object *object;
bb6c2fba 1329 unsigned mode;
02e54220
PH
1330 if (get_sha1_with_mode(revs->def, sha1, &mode))
1331 die("bad default revision '%s'", revs->def);
1332 object = get_reference(revs, revs->def, sha1, 0);
1333 add_pending_object_with_mode(revs, object, revs->def, mode);
ae563542 1334 }
8efdc326 1335
b7bb760d
LT
1336 /* Did the user ask for any diff output? Run the diff! */
1337 if (revs->diffopt.output_format & ~DIFF_FORMAT_NO_OUTPUT)
1338 revs->diff = 1;
1339
0faf2da7
AL
1340 /* Pickaxe, diff-filter and rename following need diffs */
1341 if (revs->diffopt.pickaxe ||
1342 revs->diffopt.filter ||
1343 DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
b7bb760d
LT
1344 revs->diff = 1;
1345
9dad9d2e 1346 if (revs->topo_order)
53069686
JH
1347 revs->limited = 1;
1348
8efdc326 1349 if (revs->prune_data) {
cd2bdc53 1350 diff_tree_setup_paths(revs->prune_data, &revs->pruning);
750f7b66 1351 /* Can't prune commits with rename following: the paths change.. */
8f67f8ae 1352 if (!DIFF_OPT_TST(&revs->diffopt, FOLLOW_RENAMES))
53b2c823 1353 revs->prune = 1;
cd2bdc53
LT
1354 if (!revs->full_diff)
1355 diff_tree_setup_paths(revs->prune_data, &revs->diffopt);
8efdc326 1356 }
cd2bdc53
LT
1357 if (revs->combine_merges) {
1358 revs->ignore_merges = 0;
0e677e1a 1359 if (revs->dense_combined_merges && !revs->diffopt.output_format)
cd2bdc53
LT
1360 revs->diffopt.output_format = DIFF_FORMAT_PATCH;
1361 }
cd2bdc53 1362 revs->diffopt.abbrev = revs->abbrev;
72ee96c0
JH
1363 if (diff_setup_done(&revs->diffopt) < 0)
1364 die("diff_setup_done failed");
8efdc326 1365
0843acfd 1366 compile_grep_patterns(&revs->grep_filter);
bd95fcd3 1367
d56651c0
SP
1368 if (revs->reverse && revs->reflog_info)
1369 die("cannot combine --reverse with --walk-reflogs");
8bb65883 1370 if (revs->rewrite_parents && revs->children.name)
f35f5603 1371 die("cannot combine --parents and --children");
d56651c0 1372
7fefda5c
AS
1373 /*
1374 * Limitations on the graph functionality
1375 */
1376 if (revs->reverse && revs->graph)
1377 die("cannot combine --reverse with --graph");
1378
1379 if (revs->reflog_info && revs->graph)
1380 die("cannot combine --walk-reflogs with --graph");
1381
ae563542
LT
1382 return left;
1383}
a4a88b2b 1384
f35f5603
JH
1385static void add_child(struct rev_info *revs, struct commit *parent, struct commit *child)
1386{
1387 struct commit_list *l = xcalloc(1, sizeof(*l));
1388
1389 l->item = child;
1390 l->next = add_decoration(&revs->children, &parent->object, l);
1391}
1392
6546b593
JH
1393static int remove_duplicate_parents(struct commit *commit)
1394{
1395 struct commit_list **pp, *p;
1396 int surviving_parents;
1397
1398 /* Examine existing parents while marking ones we have seen... */
1399 pp = &commit->parents;
1400 while ((p = *pp) != NULL) {
1401 struct commit *parent = p->item;
1402 if (parent->object.flags & TMP_MARK) {
1403 *pp = p->next;
1404 continue;
1405 }
1406 parent->object.flags |= TMP_MARK;
1407 pp = &p->next;
1408 }
1409 /* count them while clearing the temporary mark */
1410 surviving_parents = 0;
1411 for (p = commit->parents; p; p = p->next) {
1412 p->item->object.flags &= ~TMP_MARK;
1413 surviving_parents++;
1414 }
1415 return surviving_parents;
1416}
1417
faf0156b
JH
1418struct merge_simplify_state {
1419 struct commit *simplified;
1420};
1421
1422static struct merge_simplify_state *locate_simplify_state(struct rev_info *revs, struct commit *commit)
1423{
1424 struct merge_simplify_state *st;
1425
1426 st = lookup_decoration(&revs->merge_simplification, &commit->object);
1427 if (!st) {
1428 st = xcalloc(1, sizeof(*st));
1429 add_decoration(&revs->merge_simplification, &commit->object, st);
1430 }
1431 return st;
1432}
1433
1434static struct commit_list **simplify_one(struct rev_info *revs, struct commit *commit, struct commit_list **tail)
6546b593
JH
1435{
1436 struct commit_list *p;
faf0156b 1437 struct merge_simplify_state *st, *pst;
6546b593
JH
1438 int cnt;
1439
faf0156b
JH
1440 st = locate_simplify_state(revs, commit);
1441
6546b593 1442 /*
6546b593
JH
1443 * Have we handled this one?
1444 */
faf0156b 1445 if (st->simplified)
6546b593
JH
1446 return tail;
1447
1448 /*
1449 * An UNINTERESTING commit simplifies to itself, so does a
1450 * root commit. We do not rewrite parents of such commit
1451 * anyway.
1452 */
1453 if ((commit->object.flags & UNINTERESTING) || !commit->parents) {
faf0156b 1454 st->simplified = commit;
6546b593
JH
1455 return tail;
1456 }
1457
1458 /*
1459 * Do we know what commit all of our parents should be rewritten to?
1460 * Otherwise we are not ready to rewrite this one yet.
1461 */
1462 for (cnt = 0, p = commit->parents; p; p = p->next) {
faf0156b
JH
1463 pst = locate_simplify_state(revs, p->item);
1464 if (!pst->simplified) {
6546b593
JH
1465 tail = &commit_list_insert(p->item, tail)->next;
1466 cnt++;
1467 }
1468 }
53030f8d
JH
1469 if (cnt) {
1470 tail = &commit_list_insert(commit, tail)->next;
6546b593 1471 return tail;
53030f8d 1472 }
6546b593
JH
1473
1474 /*
1475 * Rewrite our list of parents.
1476 */
faf0156b
JH
1477 for (p = commit->parents; p; p = p->next) {
1478 pst = locate_simplify_state(revs, p->item);
1479 p->item = pst->simplified;
1480 }
6546b593
JH
1481 cnt = remove_duplicate_parents(commit);
1482
1483 /*
1484 * It is possible that we are a merge and one side branch
1485 * does not have any commit that touches the given paths;
1486 * in such a case, the immediate parents will be rewritten
1487 * to different commits.
1488 *
1489 * o----X X: the commit we are looking at;
1490 * / / o: a commit that touches the paths;
1491 * ---o----'
1492 *
1493 * Further reduce the parents by removing redundant parents.
1494 */
1495 if (1 < cnt) {
1496 struct commit_list *h = reduce_heads(commit->parents);
1497 cnt = commit_list_count(h);
1498 free_commit_list(commit->parents);
1499 commit->parents = h;
1500 }
1501
1502 /*
1503 * A commit simplifies to itself if it is a root, if it is
1504 * UNINTERESTING, if it touches the given paths, or if it is a
1505 * merge and its parents simplifies to more than one commits
1506 * (the first two cases are already handled at the beginning of
1507 * this function).
1508 *
1509 * Otherwise, it simplifies to what its sole parent simplifies to.
1510 */
1511 if (!cnt ||
1512 (commit->object.flags & UNINTERESTING) ||
1513 !(commit->object.flags & TREESAME) ||
1514 (1 < cnt))
faf0156b
JH
1515 st->simplified = commit;
1516 else {
1517 pst = locate_simplify_state(revs, commit->parents->item);
1518 st->simplified = pst->simplified;
1519 }
6546b593
JH
1520 return tail;
1521}
1522
1523static void simplify_merges(struct rev_info *revs)
1524{
1525 struct commit_list *list;
1526 struct commit_list *yet_to_do, **tail;
1527
5eac739e
JH
1528 if (!revs->topo_order)
1529 sort_in_topological_order(&revs->commits, revs->lifo);
1530 if (!revs->prune)
1531 return;
65347030 1532
6546b593
JH
1533 /* feed the list reversed */
1534 yet_to_do = NULL;
1535 for (list = revs->commits; list; list = list->next)
1536 commit_list_insert(list->item, &yet_to_do);
1537 while (yet_to_do) {
1538 list = yet_to_do;
1539 yet_to_do = NULL;
1540 tail = &yet_to_do;
1541 while (list) {
1542 struct commit *commit = list->item;
1543 struct commit_list *next = list->next;
1544 free(list);
1545 list = next;
faf0156b 1546 tail = simplify_one(revs, commit, tail);
6546b593
JH
1547 }
1548 }
1549
1550 /* clean up the result, removing the simplified ones */
1551 list = revs->commits;
1552 revs->commits = NULL;
1553 tail = &revs->commits;
1554 while (list) {
1555 struct commit *commit = list->item;
1556 struct commit_list *next = list->next;
faf0156b 1557 struct merge_simplify_state *st;
6546b593
JH
1558 free(list);
1559 list = next;
faf0156b
JH
1560 st = locate_simplify_state(revs, commit);
1561 if (st->simplified == commit)
6546b593
JH
1562 tail = &commit_list_insert(commit, tail)->next;
1563 }
6546b593
JH
1564}
1565
f35f5603
JH
1566static void set_children(struct rev_info *revs)
1567{
1568 struct commit_list *l;
1569 for (l = revs->commits; l; l = l->next) {
1570 struct commit *commit = l->item;
1571 struct commit_list *p;
1572
1573 for (p = commit->parents; p; p = p->next)
1574 add_child(revs, p->item, commit);
1575 }
1576}
1577
cc0e6c5a 1578int prepare_revision_walk(struct rev_info *revs)
a4a88b2b 1579{
1f1e895f 1580 int nr = revs->pending.nr;
94d23673 1581 struct object_array_entry *e, *list;
cd2bdc53 1582
94d23673 1583 e = list = revs->pending.objects;
1f1e895f
LT
1584 revs->pending.nr = 0;
1585 revs->pending.alloc = 0;
1586 revs->pending.objects = NULL;
1587 while (--nr >= 0) {
94d23673 1588 struct commit *commit = handle_commit(revs, e->item, e->name);
cd2bdc53
LT
1589 if (commit) {
1590 if (!(commit->object.flags & SEEN)) {
1591 commit->object.flags |= SEEN;
1592 insert_by_date(commit, &revs->commits);
1593 }
1594 }
94d23673 1595 e++;
cd2bdc53 1596 }
94d23673 1597 free(list);
cd2bdc53 1598
ba1d4505 1599 if (revs->no_walk)
cc0e6c5a 1600 return 0;
a4a88b2b 1601 if (revs->limited)
cc0e6c5a
AR
1602 if (limit_list(revs) < 0)
1603 return -1;
a4a88b2b 1604 if (revs->topo_order)
23c17d4a 1605 sort_in_topological_order(&revs->commits, revs->lifo);
6546b593
JH
1606 if (revs->simplify_merges)
1607 simplify_merges(revs);
f35f5603
JH
1608 if (revs->children.name)
1609 set_children(revs);
cc0e6c5a 1610 return 0;
a4a88b2b
LT
1611}
1612
cc0e6c5a
AR
1613enum rewrite_result {
1614 rewrite_one_ok,
1615 rewrite_one_noparents,
1616 rewrite_one_error,
1617};
1618
1619static enum rewrite_result rewrite_one(struct rev_info *revs, struct commit **pp)
765ac8ec 1620{
fce87ae5
AG
1621 struct commit_list *cache = NULL;
1622
765ac8ec
LT
1623 for (;;) {
1624 struct commit *p = *pp;
3381c790 1625 if (!revs->limited)
fce87ae5 1626 if (add_parents_to_list(revs, p, &revs->commits, &cache) < 0)
cc0e6c5a 1627 return rewrite_one_error;
6631c736 1628 if (p->parents && p->parents->next)
cc0e6c5a 1629 return rewrite_one_ok;
7dc0fe3b
LT
1630 if (p->object.flags & UNINTERESTING)
1631 return rewrite_one_ok;
1632 if (!(p->object.flags & TREESAME))
cc0e6c5a 1633 return rewrite_one_ok;
765ac8ec 1634 if (!p->parents)
cc0e6c5a 1635 return rewrite_one_noparents;
765ac8ec
LT
1636 *pp = p->parents->item;
1637 }
1638}
1639
cc0e6c5a 1640static int rewrite_parents(struct rev_info *revs, struct commit *commit)
765ac8ec
LT
1641{
1642 struct commit_list **pp = &commit->parents;
1643 while (*pp) {
1644 struct commit_list *parent = *pp;
cc0e6c5a
AR
1645 switch (rewrite_one(revs, &parent->item)) {
1646 case rewrite_one_ok:
1647 break;
1648 case rewrite_one_noparents:
765ac8ec
LT
1649 *pp = parent->next;
1650 continue;
cc0e6c5a
AR
1651 case rewrite_one_error:
1652 return -1;
765ac8ec
LT
1653 }
1654 pp = &parent->next;
1655 }
11d65967 1656 remove_duplicate_parents(commit);
cc0e6c5a 1657 return 0;
765ac8ec
LT
1658}
1659
8ecae9b0
JH
1660static int commit_match(struct commit *commit, struct rev_info *opt)
1661{
0843acfd 1662 if (!opt->grep_filter.pattern_list)
8ecae9b0 1663 return 1;
0843acfd 1664 return grep_buffer(&opt->grep_filter,
2d10c555
JH
1665 NULL, /* we say nothing, not even filename */
1666 commit->buffer, strlen(commit->buffer));
8ecae9b0
JH
1667}
1668
f35f5603
JH
1669static inline int want_ancestry(struct rev_info *revs)
1670{
8bb65883 1671 return (revs->rewrite_parents || revs->children.name);
f35f5603
JH
1672}
1673
252a7c02
LT
1674enum commit_action simplify_commit(struct rev_info *revs, struct commit *commit)
1675{
1676 if (commit->object.flags & SHOWN)
1677 return commit_ignore;
4d6acb70 1678 if (revs->unpacked && has_sha1_pack(commit->object.sha1))
252a7c02 1679 return commit_ignore;
3131b713
LT
1680 if (revs->show_all)
1681 return commit_show;
252a7c02
LT
1682 if (commit->object.flags & UNINTERESTING)
1683 return commit_ignore;
1684 if (revs->min_age != -1 && (commit->date > revs->min_age))
1685 return commit_ignore;
1686 if (revs->no_merges && commit->parents && commit->parents->next)
1687 return commit_ignore;
1688 if (!commit_match(commit, revs))
1689 return commit_ignore;
53b2c823 1690 if (revs->prune && revs->dense) {
252a7c02 1691 /* Commit without changes? */
7dc0fe3b 1692 if (commit->object.flags & TREESAME) {
252a7c02 1693 /* drop merges unless we want parenthood */
f35f5603 1694 if (!want_ancestry(revs))
252a7c02
LT
1695 return commit_ignore;
1696 /* non-merge - always ignore it */
1697 if (!commit->parents || !commit->parents->next)
1698 return commit_ignore;
1699 }
f35f5603 1700 if (want_ancestry(revs) && rewrite_parents(revs, commit) < 0)
252a7c02
LT
1701 return commit_error;
1702 }
1703 return commit_show;
1704}
1705
d5db6c9e 1706static struct commit *get_revision_1(struct rev_info *revs)
a4a88b2b 1707{
d5db6c9e 1708 if (!revs->commits)
a4a88b2b 1709 return NULL;
a4a88b2b 1710
765ac8ec 1711 do {
cb115748
LT
1712 struct commit_list *entry = revs->commits;
1713 struct commit *commit = entry->item;
ea5ed3ab 1714
cb115748
LT
1715 revs->commits = entry->next;
1716 free(entry);
2a0925be 1717
8860fd42
JS
1718 if (revs->reflog_info)
1719 fake_reflog_parent(revs->reflog_info, commit);
1720
2a0925be
LT
1721 /*
1722 * If we haven't done the list limiting, we need to look at
be7db6e5
LT
1723 * the parents here. We also need to do the date-based limiting
1724 * that we'd otherwise have done in limit_list().
2a0925be 1725 */
be7db6e5 1726 if (!revs->limited) {
744f4985 1727 if (revs->max_age != -1 &&
86ab4906
JH
1728 (commit->date < revs->max_age))
1729 continue;
fce87ae5 1730 if (add_parents_to_list(revs, commit, &revs->commits, NULL) < 0)
ed62089c
JH
1731 die("Failed to traverse parents of commit %s",
1732 sha1_to_hex(commit->object.sha1));
be7db6e5 1733 }
744f4985 1734
252a7c02
LT
1735 switch (simplify_commit(revs, commit)) {
1736 case commit_ignore:
8ecae9b0 1737 continue;
252a7c02 1738 case commit_error:
ed62089c
JH
1739 die("Failed to simplify parents of commit %s",
1740 sha1_to_hex(commit->object.sha1));
252a7c02
LT
1741 default:
1742 return commit;
384e99a4 1743 }
765ac8ec
LT
1744 } while (revs->commits);
1745 return NULL;
1746}
d5db6c9e 1747
86ab4906
JH
1748static void gc_boundary(struct object_array *array)
1749{
1750 unsigned nr = array->nr;
1751 unsigned alloc = array->alloc;
1752 struct object_array_entry *objects = array->objects;
1753
1754 if (alloc <= nr) {
1755 unsigned i, j;
1756 for (i = j = 0; i < nr; i++) {
1757 if (objects[i].item->flags & SHOWN)
1758 continue;
1759 if (i != j)
1760 objects[j] = objects[i];
1761 j++;
1762 }
892ae6bf 1763 for (i = j; i < nr; i++)
86ab4906
JH
1764 objects[i].item = NULL;
1765 array->nr = j;
1766 }
1767}
1768
4603ec0f
AS
1769static void create_boundary_commit_list(struct rev_info *revs)
1770{
1771 unsigned i;
1772 struct commit *c;
1773 struct object_array *array = &revs->boundary_commits;
1774 struct object_array_entry *objects = array->objects;
1775
1776 /*
1777 * If revs->commits is non-NULL at this point, an error occurred in
1778 * get_revision_1(). Ignore the error and continue printing the
1779 * boundary commits anyway. (This is what the code has always
1780 * done.)
1781 */
1782 if (revs->commits) {
1783 free_commit_list(revs->commits);
1784 revs->commits = NULL;
1785 }
1786
1787 /*
1788 * Put all of the actual boundary commits from revs->boundary_commits
1789 * into revs->commits
1790 */
1791 for (i = 0; i < array->nr; i++) {
1792 c = (struct commit *)(objects[i].item);
1793 if (!c)
1794 continue;
1795 if (!(c->object.flags & CHILD_SHOWN))
1796 continue;
1797 if (c->object.flags & (SHOWN | BOUNDARY))
1798 continue;
1799 c->object.flags |= BOUNDARY;
1800 commit_list_insert(c, &revs->commits);
1801 }
1802
1803 /*
1804 * If revs->topo_order is set, sort the boundary commits
1805 * in topological order
1806 */
1807 sort_in_topological_order(&revs->commits, revs->lifo);
1808}
1809
7fefda5c 1810static struct commit *get_revision_internal(struct rev_info *revs)
d5db6c9e
JH
1811{
1812 struct commit *c = NULL;
86ab4906
JH
1813 struct commit_list *l;
1814
1815 if (revs->boundary == 2) {
4603ec0f
AS
1816 /*
1817 * All of the normal commits have already been returned,
1818 * and we are now returning boundary commits.
1819 * create_boundary_commit_list() has populated
1820 * revs->commits with the remaining commits to return.
1821 */
1822 c = pop_commit(&revs->commits);
1823 if (c)
1824 c->object.flags |= SHOWN;
9c5e66e9
JS
1825 return c;
1826 }
1827
86ab4906
JH
1828 /*
1829 * Now pick up what they want to give us
1830 */
8839ac94
JH
1831 c = get_revision_1(revs);
1832 if (c) {
1833 while (0 < revs->skip_count) {
1834 revs->skip_count--;
1835 c = get_revision_1(revs);
1836 if (!c)
1837 break;
1838 }
86ab4906
JH
1839 }
1840
1841 /*
1842 * Check the max_count.
1843 */
d5db6c9e
JH
1844 switch (revs->max_count) {
1845 case -1:
1846 break;
1847 case 0:
86ab4906
JH
1848 c = NULL;
1849 break;
d5db6c9e
JH
1850 default:
1851 revs->max_count--;
1852 }
86ab4906 1853
c33d8593
JH
1854 if (c)
1855 c->object.flags |= SHOWN;
1856
1857 if (!revs->boundary) {
d5db6c9e 1858 return c;
c33d8593 1859 }
86ab4906
JH
1860
1861 if (!c) {
1862 /*
1863 * get_revision_1() runs out the commits, and
1864 * we are done computing the boundaries.
1865 * switch to boundary commits output mode.
1866 */
1867 revs->boundary = 2;
4603ec0f
AS
1868
1869 /*
1870 * Update revs->commits to contain the list of
1871 * boundary commits.
1872 */
1873 create_boundary_commit_list(revs);
1874
3c68d67b 1875 return get_revision_internal(revs);
86ab4906
JH
1876 }
1877
1878 /*
1879 * boundary commits are the commits that are parents of the
1880 * ones we got from get_revision_1() but they themselves are
1881 * not returned from get_revision_1(). Before returning
1882 * 'c', we need to mark its parents that they could be boundaries.
1883 */
1884
1885 for (l = c->parents; l; l = l->next) {
1886 struct object *p;
1887 p = &(l->item->object);
c33d8593 1888 if (p->flags & (CHILD_SHOWN | SHOWN))
86ab4906
JH
1889 continue;
1890 p->flags |= CHILD_SHOWN;
1891 gc_boundary(&revs->boundary_commits);
1892 add_object_array(p, NULL, &revs->boundary_commits);
1893 }
1894
1895 return c;
d5db6c9e 1896}
7fefda5c
AS
1897
1898struct commit *get_revision(struct rev_info *revs)
1899{
498bcd31
TR
1900 struct commit *c;
1901 struct commit_list *reversed;
1902
1903 if (revs->reverse) {
1904 reversed = NULL;
1905 while ((c = get_revision_internal(revs))) {
1906 commit_list_insert(c, &reversed);
1907 }
1908 revs->commits = reversed;
1909 revs->reverse = 0;
1910 revs->reverse_output_stage = 1;
1911 }
1912
1913 if (revs->reverse_output_stage)
1914 return pop_commit(&revs->commits);
1915
1916 c = get_revision_internal(revs);
7fefda5c
AS
1917 if (c && revs->graph)
1918 graph_update(revs->graph, c);
1919 return c;
1920}